Page MenuHomeFreeBSD
Differential D18837

Implement shmat(2) flag SHM_REMAP.
ClosedPublic
Actions

Authored by kib on Jan 14 2019, 8:24 AM.
Tags
None
Referenced Files
F91537802: D18837.id52848.diff
Mon, Aug 19, 1:42 AM
Unknown Object (File)
Sun, Aug 18, 9:48 AM
Unknown Object (File)
Mon, Aug 12, 8:36 PM
Unknown Object (File)
Sun, Aug 4, 2:06 PM
Unknown Object (File)
Thu, Aug 1, 6:33 PM
Unknown Object (File)
Mon, Jul 29, 6:45 PM
Unknown Object (File)
Mon, Jul 29, 7:55 AM
Unknown Object (File)
Jul 14 2024, 1:38 AM
View All 37 Files
Subscribers
imp
menyy_mellanox.com
slavash

Details

Reviewers
alc
markj
ngie
Group Reviewers
manpages
Commits
rS343082: Implement shmat(2) flag SHM_REMAP.
rS343081: Trim spaces at the end of lines.
Summary

Based on the description in Linux man page.

Sponsored by: Mellanox Technologies

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jan 14 2019, 8:24 AM
Herald added a reviewer: ngie. · View Herald TranscriptJan 14 2019, 8:24 AM
Herald added a reviewer: manpages. · View Herald Transcript
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B21948: Diff 52822.Jan 14 2019, 8:24 AM
kib updated this revision to Diff 52823.Jan 14 2019, 8:27 AM
kib edited the summary of this revision. (Show Details)

Bump man page date.

Harbormaster completed remote builds in B21949: Diff 52823.Jan 14 2019, 8:27 AM
markj added a comment.EditedJan 14 2019, 6:09 PM

This seems ok to me. I'm not sure about modifying the NetBSD tests, might be nice to wrap the changes with #ifdef SHM_REMAP if they are to be upstreamed.

Seems like in the future we could implement MAP_REMAP with find_space != VMFS_NO_SPACE to provide the semantics needed for Linux's mremap(2).

lib/libc/sys/shmat.2
84 ↗(On Diff #52823)

"is specified and the passed"

86 ↗(On Diff #52823)

"existing mappings"?

90 ↗(On Diff #52823)

addresses -> address

I would also s/already has/contains/.

kib updated this revision to Diff 52848.Jan 15 2019, 3:55 AM

Fix grammar.
Wrap new test with #ifdef SHM_REMAP.
Document ENOMEM.

Harbormaster completed remote builds in B21964: Diff 52848.Jan 15 2019, 3:55 AM
ngie accepted this revision.Jan 15 2019, 8:17 AM

The test changes are ok. I figure I'll have to make a pass over the tree anyhow to find what all may have changed in the past year under contrib/netbsd-tests, so there's no time like the present-ish to do it.

contrib/netbsd-tests/kernel/t_sysv.c
864 ↗(On Diff #52848)

Hmmm... 4160 is a curious number (this is copied from other tests, so the voodoo-ness comes from NetBSD).

This revision is now accepted and ready to land.Jan 15 2019, 8:17 AM
ngie added inline comments.Jan 15 2019, 8:19 AM
lib/libc/sys/shmat.2
86 ↗(On Diff #52848)

.Dv NULL should be used instead of NULL here and elsewhere, since it's a constant.

markj accepted this revision.Jan 15 2019, 4:45 PM
markj added inline comments.
lib/libc/sys/shmat.2
127 ↗(On Diff #52848)

"due to the amount of available space being smaller"

128 ↗(On Diff #52848)

"pre-existing mappings are in the range"

Closed by commit rS343081: Trim spaces at the end of lines. (authored by kib). · Explain WhyJan 16 2019, 5:09 AM
This revision was automatically updated to reflect the committed changes.
kib reopened this revision.Jan 16 2019, 5:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2019, 5:16 AM
Closed by commit rS343082: Implement shmat(2) flag SHM_REMAP. (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
contrib/
netbsd-tests/
kernel/
60 lines
lib/
libc/
sys/
35 lines
sys/
kern/
10 lines
sys/
1 line
vm/
1 line
10 lines

Diff 52882

View Options

head/contrib/netbsd-tests/kernel/t_sysv.c

Loading...
View Options

head/lib/libc/sys/shmat.2

Loading...
View Options

head/sys/kern/sysv_shm.c

Loading...
View Options

head/sys/sys/shm.h

Loading...
View Options

head/sys/vm/vm_map.h

Loading...
View Options

head/sys/vm/vm_map.c

Loading...