Page MenuHomeFreeBSD

Don't set if_linkmib for vlan(4).
ClosedPublic

Authored by markj on Jan 8 2019, 1:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 30, 1:25 AM
Unknown Object (File)
Wed, Sep 24, 4:51 AM
Unknown Object (File)
Wed, Sep 24, 4:49 AM
Unknown Object (File)
Wed, Sep 24, 4:49 AM
Unknown Object (File)
Sat, Sep 20, 10:04 AM
Unknown Object (File)
Thu, Sep 18, 1:42 PM
Unknown Object (File)
Thu, Sep 18, 1:33 PM
Unknown Object (File)
Thu, Sep 18, 1:33 PM
Subscribers

Details

Summary

It doesn't really make sense:

  • the structure being exported isn't a MIB,
  • the structure being exported is private to the kernel and always has been, and
  • no other drivers in widespread use implement a link-specific MIB.

Moreover, the IFDATA_LINKSPECIFIC interface allows a privileged user to
overwrite a bunch of internal state without any validation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp added a subscriber: kp.

LGTM.

This revision is now accepted and ready to land.Jan 8 2019, 8:14 AM
  • Also collapse ifv_linkmib into the parent structure.
This revision now requires review to proceed.Jan 8 2019, 5:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2019, 4:47 PM
This revision was automatically updated to reflect the committed changes.