Page MenuHomeFreeBSD

Add NVMe drive to NOIOB quirk list
ClosedPublic

Authored by chuck on Mon, Jan 7, 3:41 PM.

Details

Summary

This is a patch from FreeBSD Bugzilla – Bug 233969

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chuck created this revision.Mon, Jan 7, 3:41 PM
chuck added reviewers: imp, ken, mav.Mon, Jan 7, 3:41 PM
mav accepted this revision.Mon, Jan 7, 3:50 PM

I have no objections, if its true.

This revision is now accepted and ready to land.Mon, Jan 7, 3:50 PM
chuck added a comment.Mon, Jan 7, 5:20 PM
In D18772#400520, @mav wrote:

I have no objections, if its true.

I don't have access to one of these devices or the spec sheet, but the Linux NVMe driver sets the quirk NVME_QUIRK_STRIPE_SIZE for this device. The Linux text associated with this quirk is:

Prefers I/O aligned to a stripe size specified in a vendor
specific Identify field.

which sounds like what the FreeBSD driver is trying to do as well. Note that the Linux driver also sets this quirk for device ID's 0x0953, 0x0a53, and 0x0a54 (i.e. same as the current driver).

imp accepted this revision.Mon, Jan 7, 7:50 PM

This works for me. There is a newer way to cope with this, but I don't think the 4600 implements this, so this change is appropriate.

This revision was automatically updated to reflect the committed changes.
chuck added a comment.Tue, Jan 8, 3:35 PM
In D18772#400655, @imp wrote:

This works for me. There is a newer way to cope with this, but I don't think the 4600 implements this, so this change is appropriate.

Out of curiosity, what is the newer way?