Add NVMe drive to NOIOB quirk list
ClosedPublic
Actions

Authored by chuck on Jan 7 2019, 3:41 PM.

Details

Reviewers

imp
ken
mav

Commits

rS342862: Add NVMe drive to NOIOB quirk list

Summary

This is a patch from FreeBSD Bugzilla – Bug 233969

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chuck created this revision.Jan 7 2019, 3:41 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 7 2019, 3:41 PM

Harbormaster completed remote builds in B21862: Diff 52632.Jan 7 2019, 3:41 PM

chuck added reviewers: imp, ken, mav.Jan 7 2019, 3:41 PM

I have no objections, if its true.

This revision is now accepted and ready to land.Jan 7 2019, 3:50 PM

In D18772#400520, @mav wrote:

I have no objections, if its true.

I don't have access to one of these devices or the spec sheet, but the Linux NVMe driver sets the quirk NVME_QUIRK_STRIPE_SIZE for this device. The Linux text associated with this quirk is:

Prefers I/O aligned to a stripe size specified in a vendor
specific Identify field.

which sounds like what the FreeBSD driver is trying to do as well. Note that the Linux driver also sets this quirk for device ID's 0x0953, 0x0a53, and 0x0a54 (i.e. same as the current driver).

This works for me. There is a newer way to cope with this, but I don't think the 4600 implements this, so this change is appropriate.

Closed by commit rS342862: Add NVMe drive to NOIOB quirk list (authored by chuck). · Explain WhyJan 8 2019, 3:31 PM

This revision was automatically updated to reflect the committed changes.

In D18772#400655, @imp wrote:

This works for me. There is a newer way to cope with this, but I don't think the 4600 implements this, so this change is appropriate.

Out of curiosity, what is the newer way?

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

nvme/

nvme_ns.c

1 line

Diff 52671

View Options

head/sys/dev/nvme/nvme_ns.c

Add NVMe drive to NOIOB quirk listClosedPublicActions