Fix error-path resource leaks in iflib registration routines
ClosedPublic
Actions

Authored by pkelsey on Jan 6 2019, 5:02 AM.

Tags

None

Referenced Files

	F166888802: D18760.id52602.diff
	Mon, Aug 17, 1:26 PM

	Unknown Object (File)
	Mon, Aug 10, 10:28 PM

	Unknown Object (File)
	Mon, Aug 10, 5:43 PM

	Unknown Object (File)
	Mon, Aug 10, 5:10 PM

	Unknown Object (File)
	Tue, Aug 4, 5:05 AM

	Unknown Object (File)
	Tue, Aug 4, 3:53 AM

	Unknown Object (File)
	Mon, Aug 3, 8:46 AM

	Unknown Object (File)
	Wed, Jul 29, 2:24 PM

View All Files

Subscribers

imp

Details

Reviewers

mmacy
shurd

Commits

rS343932: MFC: r343288
rS343288: Fix various resource leaks that can occur in the error paths of

Summary

This patch fixes various resource leaks that can occur in the error paths of iflib_device_register() and iflib_pseudo_register().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkelsey created this revision.Jan 6 2019, 5:02 AM

Herald added a subscriber: ae. · View Herald TranscriptJan 6 2019, 5:02 AM

Looks good, only a tiny nitpick on the fail label.

This revision is now accepted and ready to land.Jan 7 2019, 9:03 PM

In D18760#400670, @shurd wrote:

Looks good, only a tiny nitpick on the fail label.

Will make them consistent prior to commit.

Closed by commit rS343288: Fix various resource leaks that can occur in the error paths of (authored by pkelsey). · Explain WhyJan 22 2019, 12:56 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJan 22 2019, 12:56 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

iflib.c

47 lines

Diff 53078

View Options

Fix error-path resource leaks in iflib registration routinesClosedPublicActions