Page MenuHomeFreeBSD
Differential D18760

Fix error-path resource leaks in iflib registration routines
ClosedPublic
Actions

Authored by pkelsey on Jan 6 2019, 5:02 AM.
Tags
None
Referenced Files
F132540901: D18760.id.diff
Fri, Oct 17, 7:53 PM
F132540900: D18760.id53078.diff
Fri, Oct 17, 7:53 PM
F132540899: D18760.id52602.diff
Fri, Oct 17, 7:53 PM
Unknown Object (File)
Fri, Oct 17, 10:55 AM
Unknown Object (File)
Thu, Oct 16, 7:10 PM
Unknown Object (File)
Thu, Oct 16, 6:34 AM
Unknown Object (File)
Thu, Oct 9, 7:56 PM
Unknown Object (File)
Thu, Oct 9, 6:38 AM
View All 86 Files
Subscribers
ae
imp

Details

Reviewers
mmacy
shurd
Commits
rS343932: MFC: r343288
rS343288: Fix various resource leaks that can occur in the error paths of
Summary

This patch fixes various resource leaks that can occur in the error paths of iflib_device_register() and iflib_pseudo_register().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkelsey created this revision.Jan 6 2019, 5:02 AM
Herald added a subscriber: ae. · View Herald TranscriptJan 6 2019, 5:02 AM
shurd accepted this revision.Jan 7 2019, 9:03 PM

Looks good, only a tiny nitpick on the fail label.

This revision is now accepted and ready to land.Jan 7 2019, 9:03 PM
pkelsey added a comment.Jan 22 2019, 12:53 AM
In D18760#400670, @shurd wrote:

Looks good, only a tiny nitpick on the fail label.

Will make them consistent prior to commit.

Closed by commit rS343288: Fix various resource leaks that can occur in the error paths of (authored by pkelsey). · Explain WhyJan 22 2019, 12:56 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJan 22 2019, 12:56 AM

Revision Contents
Changeset List

PathSize
head/
sys/
net/
47 lines

Diff 53078

View Options

head/sys/net/iflib.c

Loading...