Differential D18664

Handle SIGIO for listening sockets
ClosedPublic
Actions

Authored by jah on Dec 27 2018, 7:48 PM.

Tags

None

Referenced Files

	F153982961: D18664.id.diff
	Sat, Apr 25, 6:19 AM

	F153930326: D18664.diff
	Fri, Apr 24, 9:30 PM

	Unknown Object (File)
	Sat, Apr 18, 10:11 PM

	Unknown Object (File)
	Sat, Apr 18, 10:11 PM

	Unknown Object (File)
	Sat, Apr 18, 3:22 PM

	Unknown Object (File)
	Sat, Apr 18, 1:57 PM

	Unknown Object (File)
	Thu, Apr 16, 4:10 AM

	Unknown Object (File)
	Sun, Apr 12, 8:39 PM

Subscribers

Details

Reviewers

glebius
tuexen
kbowling

Group Reviewers

Commits

rS343005: Handle SIGIO for listening sockets

Summary

r319722 separated portions of struct socket and the socket I/O path that are specific to listening sockets from those which are specific to dataflow sockets. Listening socket connection notifications are now handled through solisten_wakeup() instead of sowakeup(), but solisten_wakeup() does not currently handle delivery of SIGIO to the owning process.

Reported by: Kenneth Adelman
PR: 234258

Test Plan

Verified that this fixes the issue reported in bug 234258 on -current

--Do we have a good place in existing unit tests to add a case for this?

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jah created this revision.Dec 27 2018, 7:48 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2018, 7:48 PM

Harbormaster completed remote builds in B21744: Diff 52348.Dec 27 2018, 7:48 PM

jah edited the test plan for this revision. (Show Details)Dec 27 2018, 7:53 PM

jah added reviewers: glebius, tuexen, kbowling, transport.

You may be able to add something to /usr/src/tests/sys/

In D18664#398479, @kbowling wrote:

You may be able to add something to /usr/src/tests/sys/

It looks like there aren't any tests that exercise SIGIO in any capacity. I'll consider adding something in a later commit.

ping...does anyone want to review?

jah edited the summary of this revision. (Show Details)Jan 13 2019, 9:28 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 13 2019, 8:34 PM

Closed by commit rS343005: Handle SIGIO for listening sockets (authored by jah). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

2 lines

Diff 52816

head/sys/kern/uipc_socket.c

Loading...