Page MenuHomeFreeBSD
Differential D18664

Handle SIGIO for listening sockets
ClosedPublic
Actions

Authored by jah on Dec 27 2018, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 2:16 PM
Unknown Object (File)
Mon, Dec 2, 3:53 AM
Unknown Object (File)
Nov 14 2024, 5:49 AM
Unknown Object (File)
Nov 6 2024, 12:33 AM
Unknown Object (File)
Oct 3 2024, 4:50 PM
Unknown Object (File)
Oct 1 2024, 1:37 PM
Unknown Object (File)
Sep 12 2024, 6:01 PM
Unknown Object (File)
Sep 9 2024, 9:51 AM
View All 41 Files
Subscribers
imp

Details

Reviewers
glebius
tuexen
kbowling
Group Reviewers
transport
Commits
rS343005: Handle SIGIO for listening sockets
Summary

r319722 separated portions of struct socket and the socket I/O path that are specific to listening sockets from those which are specific to dataflow sockets. Listening socket connection notifications are now handled through solisten_wakeup() instead of sowakeup(), but solisten_wakeup() does not currently handle delivery of SIGIO to the owning process.

Reported by: Kenneth Adelman
PR: 234258

Test Plan

Verified that this fixes the issue reported in bug 234258 on -current

--Do we have a good place in existing unit tests to add a case for this?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jah created this revision.Dec 27 2018, 7:48 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 27 2018, 7:48 PM
Harbormaster completed remote builds in B21744: Diff 52348.Dec 27 2018, 7:48 PM
jah edited the test plan for this revision. (Show Details)Dec 27 2018, 7:53 PM
jah added reviewers: glebius, tuexen, kbowling, transport.
kbowling added a comment.Dec 29 2018, 6:51 AM

You may be able to add something to /usr/src/tests/sys/

jah added a comment.Jan 1 2019, 1:44 PM
In D18664#398479, @kbowling wrote:

You may be able to add something to /usr/src/tests/sys/

It looks like there aren't any tests that exercise SIGIO in any capacity. I'll consider adding something in a later commit.

jah added a comment.Jan 4 2019, 5:30 PM

ping...does anyone want to review?

jah edited the summary of this revision. (Show Details)Jan 13 2019, 9:28 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 13 2019, 8:34 PM
Closed by commit rS343005: Handle SIGIO for listening sockets (authored by jah). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
2 lines

Diff 52816

View Options

head/sys/kern/uipc_socket.c

Loading...