Use caph_cache_catpages() in ping(8).
ClosedPublic
Actions

Authored by markj on Dec 11 2018, 4:19 PM.

Details

Reviewers

emaste
oshogbo

Group Reviewers

capsicum

Commits

rS341837: Use Capsicum helpers in ping(8).

Summary

Otherwise sendto() errors result in a SIGTRAP if kern.trap_enotcap=1.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 11 2018, 4:19 PM

Herald added a subscriber: jonathan. · View Herald TranscriptDec 11 2018, 4:19 PM

Harbormaster completed remote builds in B21495: Diff 51866.Dec 11 2018, 4:19 PM

markj added reviewers: emaste, oshogbo, capsicum.Dec 11 2018, 4:19 PM

Maybe lets use cap_helpers in whole file

Use helpers throughout ping(8).

Harbormaster completed remote builds in B21497: Diff 51869.Dec 11 2018, 7:19 PM

Remove unneeded ENOSYS checks.

Harbormaster completed remote builds in B21498: Diff 51870.Dec 11 2018, 7:21 PM

oshogbo requested changes to this revision.Dec 11 2018, 10:31 PM

oshogbo added inline comments.

sbin/ping/ping.c
810 ↗	(On Diff #51869)	We don't need to check ernno using caph_*
317 ↗	(On Diff #51866)	Not sure why we removed this?

This revision now requires changes to proceed.Dec 11 2018, 10:31 PM

markj marked 2 inline comments as done.Dec 11 2018, 10:39 PM

markj added inline comments.

sbin/ping/ping.c
810 ↗	(On Diff #51869)	Are you looking at an old version of the diff?
317 ↗	(On Diff #51866)	Not sure what you're referring to.

oshogbo accepted this revision.Dec 11 2018, 10:40 PM

oshogbo added inline comments.

sbin/ping/ping.c
810 ↗	(On Diff #51869)	Aghr porbably sorry.

This revision is now accepted and ready to land.Dec 11 2018, 10:40 PM

Closed by commit rS341837: Use Capsicum helpers in ping(8). (authored by markj). · Explain WhyDec 12 2018, 2:34 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptDec 12 2018, 2:34 AM

Revision Contents
Changeset List

Path

Size

head/

sbin/

ping/

ping.c

21 lines

Diff 51891

View Options

Use caph_cache_catpages() in ping(8).ClosedPublicActions