top(1): Add ability to sort by cpu core number
Needs ReviewPublic
Actions

Authored by farrokhi on Dec 9 2018, 5:47 PM.

Details

Reviewers

eadler
markj
bcr

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
manpages

Summary

When binding processes/threads to certain cpu cores, being able to sort top(1) output by core number would be very useful. This patch adds the ability to sort the top(1) output by cpu core.

Test Plan

Apply the patch
Run top -o core

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21470
Build 20788: arc lint + arc unit

Event Timeline

farrokhi created this revision.Dec 9 2018, 5:47 PM

Owners added a reviewer: Restricted Owners Package.Dec 9 2018, 5:47 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 9 2018, 5:47 PM

Harbormaster completed remote builds in B21457: Diff 51781.Dec 9 2018, 5:48 PM

Update man page

Herald added a reviewer: manpages. · View Herald TranscriptDec 9 2018, 5:53 PM

Harbormaster completed remote builds in B21458: Diff 51782.Dec 9 2018, 5:55 PM

You need to bump the .Dd at the beginning of the man page when making the commit as this is a content change. The change itself looks good from the manpage side of things.

This revision is now accepted and ready to land.Dec 9 2018, 6:19 PM

Bumped .Dd at the beginning of the man page

This revision now requires review to proceed.Dec 10 2018, 8:16 AM

Harbormaster completed remote builds in B21470: Diff 51798.Dec 10 2018, 8:16 AM

I would suggest explaining the difference between -o cpu and -o core in the description of the -o option.

I find it odd to use ki_lastcpu in the sort key. On a system with many idle processes it means that we will not show a busy thread on CPU 0. For your use-case, shouldn't a running thread always come before an idle thread?

pstef added a subscriber: pstef.Aug 15 2021, 8:22 PM