Remove MD __sys_* private symbols.
ClosedPublic
Actions

Authored by brooks on Dec 3 2018, 11:40 PM.

Details

Reviewers

Commits

rS341509: Remove MD __sys_* private symbols.

Summary

No references to any of these exist in the tree. The list was also
erratic with different architectures exporting different things
(arm64 and riscv exported none).

Test Plan

Needs a universe build.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Dec 3 2018, 11:40 PM

Harbormaster completed remote builds in B21347: Diff 51559.Dec 3 2018, 11:42 PM

I think that our private export is too large. Ideally it would be trimmed down to the symbols used by libthr.

This revision is now accepted and ready to land.Dec 3 2018, 11:54 PM

In D18425#392258, @kib wrote:

I think that our private export is too large. Ideally it would be trimmed down to the symbols used by libthr.

Yeah, I didn't find evidence of anything in the amd64 specific one being used anywhere (outside some obsolete KSE tests). I'm going to limit the change to this for now so I can rebase D15637 on it and get that out of the way, but a major cleanup seems like a good idea for 13.

make tinderbox passed for me.

Closed by commit rS341509: Remove MD __sys_* private symbols. (authored by brooks). · Explain WhyDec 5 2018, 12:46 AM

This revision was automatically updated to reflect the committed changes.

Herald added subscribers: andrew, imp. · View Herald TranscriptDec 5 2018, 12:46 AM