Page MenuHomeFreeBSD

Fix newvers.sh with BUILD_WITH_STRICT_TMPPATH=1
ClosedPublic

Authored by arichardson on Thu, Nov 29, 10:34 AM.

Details

Summary

newvers.sh runs mkfifo which did not exist before this change.
However, I didn't notice before because it is run from a function
where a missing command does cause a noticeable failure.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.Thu, Nov 29, 10:34 AM
emaste accepted this revision.Thu, Nov 29, 3:19 PM
emaste added subscribers: kib, markj.

LGTM. One of either @kib or @markj suggested eliminating the mkfifo but I believe we cannot without a more capable shell.

This revision is now accepted and ready to land.Thu, Nov 29, 3:19 PM
markj accepted this revision.Thu, Nov 29, 3:23 PM

Oh huh. What's the problem with:

$git_cmd ... | while read smode ...; do
...
done

? A quick test suggests that /bin/sh does indeed support that.

Anyway, LGTM.

Oh, maybe I'm conflating a different comment with something about mkfifo, but it was in D15968. In any case, the issue is that with cmd | while ... a return in the while loop returns from the subshell, not the function. There's a decent Stack Overflow discussion at https://stackoverflow.com/questions/13726764/while-loop-subshell-dilemma-in-bash

This revision was automatically updated to reflect the committed changes.