Adjust v_freecnt when blacklisting pages.
ClosedPublic
Actions

Authored by markj on Nov 29 2018, 12:11 AM.

Details

Reviewers

alc
kib
mav

Commits

rS341247: Update the free page count when blacklisting pages.

Summary

This bug has been around for a while, but the blacklisting facility was
only used if you specified pages with the vm.blacklist tunable.
However, r332182 added a new use. This problem is particularly
pronounced on 11.2 where we expect vm_phys to return a page if
v_free_count says that there's one available.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 29 2018, 12:11 AM

Harbormaster completed remote builds in B21254: Diff 51307.Nov 29 2018, 12:12 AM

markj added reviewers: alc, kib, mav.Nov 29 2018, 12:14 AM

wollman added a subscriber: wollman.Nov 29 2018, 2:01 AM

kib accepted this revision.Nov 29 2018, 7:33 AM

This revision is now accepted and ready to land.Nov 29 2018, 7:33 AM

alc accepted this revision.Nov 29 2018, 3:37 PM

Looks good to me. I applied the version for 11 you've proposed on IRC and so far the benchmark runs for about 20 minutes, while previously crashed after about 5. I'll let you know if it ever happen again.

Closed by commit rS341247: Update the free page count when blacklisting pages. (authored by markj). · Explain WhyNov 29 2018, 4:31 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 4:31 PM