Page MenuHomeFreeBSD
Differential D18353

Rename www/mod_security3 to www/modsecurity3.
ClosedPublic
Actions

Authored by des on Nov 27 2018, 7:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 31, 5:38 AM
Unknown Object (File)
Mon, Oct 27, 1:19 PM
Unknown Object (File)
Sat, Oct 25, 1:24 AM
Unknown Object (File)
Thu, Oct 23, 2:43 PM
Unknown Object (File)
Fri, Oct 17, 3:47 AM
Unknown Object (File)
Wed, Oct 15, 9:25 AM
Unknown Object (File)
Mon, Oct 13, 3:57 PM
Unknown Object (File)
Mon, Oct 6, 6:11 AM
View All Files
Subscribers
joneum
mat

Details

Reviewers
marieheleneka_gmail.com
marius.h_lden.org
Commits
rP486012: Rename www/mod_security3 to security/modsecurity3. It is not an Apache
Summary

See #233351.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

des created this revision.Nov 27 2018, 7:10 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 27 2018, 7:10 AM
joneum added a subscriber: joneum.Nov 27 2018, 8:06 AM
joneum added inline comments.
security/modsecurity3/Makefile
37

what you exactly mean whit "??"

joneum added inline comments.Nov 27 2018, 8:10 AM
security/modsecurity3/Makefile
13

There is a LICENSE File inside. Pls add "LICENSE_FILE"

marieheleneka_gmail.com added a reviewer: marius.h_lden.org.Nov 27 2018, 8:26 AM
des marked 4 inline comments as done.Nov 27 2018, 8:28 AM
des added inline comments.
security/modsecurity3/Makefile
13

This will be handled by the maintainer in the upcoming upgrade to 3.0.3.

37

https://www.freebsd.org/doc/en/books/porters-handbook/conflicts.html

marieheleneka_gmail.com accepted this revision.Nov 27 2018, 8:34 AM

Looks good to me.
I added port maintainer (Marius Halden) to reviewers list as well.

This revision is now accepted and ready to land.Nov 27 2018, 8:34 AM
des marked 2 inline comments as done.Nov 27 2018, 8:43 AM
des updated this revision to Diff 51156.EditedNov 27 2018, 8:51 AM

Fix date in MOVED and add www/nginx PORTREVISION bump that fell out when I generated the diff.

This revision now requires review to proceed.Nov 27 2018, 8:51 AM
joneum added inline comments.Nov 27 2018, 8:58 AM
security/modsecurity3/Makefile
37

I can not find anything under this link. What exactly does "??" here?

des removed a subscriber: joneum.Nov 27 2018, 9:08 AM
joneum added a subscriber: joneum.Nov 27 2018, 9:14 AM
marius.h_lden.org added inline comments.Nov 27 2018, 10:00 AM
security/modsecurity3/Makefile
20

Why was uses gnome added?

marius.h_lden.org accepted this revision.Nov 27 2018, 10:01 AM

Just ignore my previous question, it's because of libxml2. Looks good to me.

This revision is now accepted and ready to land.Nov 27 2018, 10:01 AM
marieheleneka_gmail.com accepted this revision.Nov 27 2018, 11:40 AM
Closed by commit rP486012: Rename www/mod_security3 to security/modsecurity3. It is not an Apache (authored by des). · Explain WhyDec 5 2018, 1:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
1 line
security/
1 line
modsecurity3/
10 lines
www/
1 line
mod_security3/
42 lines
9 lines
9 lines
24 lines
nginx-devel/
2 lines
2 lines
2 lines
nginx/
2 lines
2 lines
security/
modsecurity3/

Diff 51154

View Options

MOVED

Loading...
View Options

security/Makefile

Loading...
View Options

security/modsecurity3/Makefile

Loading...
View Options

security/modsecurity3/distinfo

Loading...
View Options

security/modsecurity3/pkg-descr

Loading...
View Options

security/modsecurity3/pkg-plist

Loading...
View Options

www/Makefile

Loading...
View Options

www/mod_security3/Makefile

Loading...
View Options

www/mod_security3/distinfo

Loading...
View Options

www/mod_security3/pkg-descr

Loading...
View Options

www/mod_security3/pkg-plist

Loading...
View Options

www/nginx-devel/Makefile

Loading...
View Options

www/nginx-devel/Makefile.extmod

Loading...
View Options

www/nginx-devel/Makefile.options.desc

Loading...
View Options

www/nginx/Makefile.extmod

Loading...
View Options

www/nginx/Makefile.options.desc

Loading...