Page MenuHomeFreeBSD

marieheleneka_gmail.com (Marie Helene Kvello-Aune)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 29 2015, 6:06 PM (181 w, 6 d)

Recent Activity

Mon, Feb 11

marieheleneka_gmail.com accepted D19146: Explain branches in ports(7)..
Mon, Feb 11, 3:34 PM

Jan 14 2019

marieheleneka_gmail.com abandoned D18839: textproc/kibana6: Declare lang/phantomjs as runtime dependency.

Patch has been widthdrawn as lang/phantomjs doesn't build on 12/13, and phantomjs is no longer maintained (see: https://github.com/ariya/phantomjs/issues/15344). The fork (https://github.com/vitallium/phantomjs/) used by this port seems abandoned as well.

Jan 14 2019, 2:43 PM
marieheleneka_gmail.com added a comment to D18839: textproc/kibana6: Declare lang/phantomjs as runtime dependency.

Missed some changes in the files/ directory. Testing the created patch before updating.

Jan 14 2019, 12:03 PM
marieheleneka_gmail.com created D18839: textproc/kibana6: Declare lang/phantomjs as runtime dependency.
Jan 14 2019, 11:36 AM

Dec 29 2018

marieheleneka_gmail.com updated the diff for D18618: Make kernel print jail ID when logging a process exit..

Made code a bit more readable by storing jid as a variable, instead of double ?: syntax.
Fixed trailing whitespace.

Dec 29 2018, 11:47 AM

Dec 20 2018

marieheleneka_gmail.com added a comment to D18618: Make kernel print jail ID when logging a process exit..
In D18618#397024, @mjg wrote:
Dec 20 2018, 11:55 AM
marieheleneka_gmail.com updated the diff for D18618: Make kernel print jail ID when logging a process exit..

Added jid to log message for sigexit as well.
Made formatting more consistent (removed a colon)

Dec 20 2018, 11:53 AM
marieheleneka_gmail.com updated the diff for D18618: Make kernel print jail ID when logging a process exit..

Fix whitespace

Dec 20 2018, 10:55 AM
marieheleneka_gmail.com created D18618: Make kernel print jail ID when logging a process exit..
Dec 20 2018, 10:46 AM

Nov 28 2018

marieheleneka_gmail.com accepted D18357: Update security/modsecurity3 to v3.0.3.
Nov 28 2018, 6:24 PM

Nov 27 2018

marieheleneka_gmail.com added a reviewer for D18357: Update security/modsecurity3 to v3.0.3: marieheleneka_gmail.com.
Nov 27 2018, 4:19 PM
marieheleneka_gmail.com added a comment to D18356: Update VTS plugin for www/nginx.

Reminder to whomever commits this: PORTREVISION is a moving target and should be updated properly when committing.

Nov 27 2018, 2:35 PM
marieheleneka_gmail.com added a reviewer for D18356: Update VTS plugin for www/nginx: joneum.
Nov 27 2018, 1:25 PM
marieheleneka_gmail.com removed a reviewer for D17522: libifconfig: Add initial support for if_bridge: marieheleneka_gmail.com.
Nov 27 2018, 11:43 AM
marieheleneka_gmail.com accepted D18353: Rename www/mod_security3 to www/modsecurity3..
Nov 27 2018, 11:40 AM
marieheleneka_gmail.com accepted D17522: libifconfig: Add initial support for if_bridge.
Nov 27 2018, 11:40 AM
marieheleneka_gmail.com accepted D18353: Rename www/mod_security3 to www/modsecurity3..

Looks good to me.
I added port maintainer (Marius Halden) to reviewers list as well.

Nov 27 2018, 8:37 AM
marieheleneka_gmail.com added a reviewer for D18353: Rename www/mod_security3 to www/modsecurity3.: marius.h_lden.org.
Nov 27 2018, 8:26 AM

Oct 13 2018

marieheleneka_gmail.com added inline comments to D17522: libifconfig: Add initial support for if_bridge.
Oct 13 2018, 4:18 PM
marieheleneka_gmail.com updated the diff for D17522: libifconfig: Add initial support for if_bridge.

Some minor corrections. Turns out it helps if I run tests on the right tree. :)

Oct 13 2018, 10:13 AM
marieheleneka_gmail.com updated the diff for D17522: libifconfig: Add initial support for if_bridge.

More trailing whitespace

Oct 13 2018, 10:07 AM
marieheleneka_gmail.com updated the diff for D17522: libifconfig: Add initial support for if_bridge.

Update according to feedback

Oct 13 2018, 10:05 AM
marieheleneka_gmail.com planned changes to D17522: libifconfig: Add initial support for if_bridge.
Oct 13 2018, 10:03 AM

Oct 11 2018

marieheleneka_gmail.com created D17522: libifconfig: Add initial support for if_bridge.
Oct 11 2018, 4:47 PM

Sep 20 2018

marieheleneka_gmail.com added a comment to D3583: Document sysctl MIBs in sctp(4).

I've not cycled back to this diff, and probably won't get to do the research necessary to document the remaining MIBs. Can this revision be committed as-is?

Sep 20 2018, 11:32 AM
marieheleneka_gmail.com abandoned D17254: Fix bug: bsdinstaller TTY hardening never applied.

Closing this revision, apparently one already exists from a year ago. D12476

Sep 20 2018, 8:43 AM
marieheleneka_gmail.com created D17254: Fix bug: bsdinstaller TTY hardening never applied.
Sep 20 2018, 8:14 AM

Jun 19 2018

marieheleneka_gmail.com abandoned D10225: libifconfig: Can now create some interfaces. Various bug fixes.

This was superseded by/included in rS329853

Jun 19 2018, 8:40 AM

Oct 4 2017

marieheleneka_gmail.com closed D12238: Implement random modulus with kern.randompid=1.

Was committed in rS323390. (This comment is only to close the revision)

Oct 4 2017, 9:45 AM

Sep 27 2017

marieheleneka_gmail.com added a comment to D12433: bsdinstall(8) hardening menu: Utilize new kern.randompid=1 behaviour.

Just adding that I've run the test procedure by creating a custom installation media and installing to a VM. Ticking the PID randomization checkbox works as intended.

Sep 27 2017, 4:42 PM

Sep 21 2017

marieheleneka_gmail.com added an edge to rS323390: If the user tries to set kern.randompid to 1 (which is meaningless), set: D12238: Implement random modulus with kern.randompid=1.
Sep 21 2017, 2:58 PM
marieheleneka_gmail.com added 1 commit(s) for D12238: Implement random modulus with kern.randompid=1: rS323390: If the user tries to set kern.randompid to 1 (which is meaningless), set.
Sep 21 2017, 2:58 PM
marieheleneka_gmail.com added a comment to D12433: bsdinstall(8) hardening menu: Utilize new kern.randompid=1 behaviour.

This builds on r323390, right?

It builds on the previous work committed in rS323390, yes.

Sep 21 2017, 2:14 PM
marieheleneka_gmail.com updated the summary of D12433: bsdinstall(8) hardening menu: Utilize new kern.randompid=1 behaviour.
Sep 21 2017, 1:53 PM
marieheleneka_gmail.com created D12433: bsdinstall(8) hardening menu: Utilize new kern.randompid=1 behaviour.
Sep 21 2017, 1:25 PM

Sep 10 2017

marieheleneka_gmail.com updated the summary of D12238: Implement random modulus with kern.randompid=1.
Sep 10 2017, 2:50 PM
marieheleneka_gmail.com updated the test plan for D12238: Implement random modulus with kern.randompid=1.
Sep 10 2017, 2:50 PM
marieheleneka_gmail.com updated the diff for D12238: Implement random modulus with kern.randompid=1.

Since the upper bound of modulus was picked somewhat randomly, change it so the math is simpler. (suggested by des@)

Sep 10 2017, 2:40 PM
marieheleneka_gmail.com updated the diff for D12238: Implement random modulus with kern.randompid=1.

Fixed bug introduced in previous revision: setting kern.randompid=0 sets it to 100
Restructured if-then-else tree to make slightly more sense while here. (feedback from des@)

Sep 10 2017, 2:32 PM

Sep 8 2017

marieheleneka_gmail.com updated the diff for D12238: Implement random modulus with kern.randompid=1.

Implement random modulus with kern.randompid=1
Fixed some incorrect assumptions (casting+abs()) and using cross-cast instead of modulus for more randomized results.

Sep 8 2017, 2:30 PM

Sep 6 2017

marieheleneka_gmail.com updated the diff for D12238: Implement random modulus with kern.randompid=1.
Sep 6 2017, 3:10 PM
marieheleneka_gmail.com added inline comments to D12238: Implement random modulus with kern.randompid=1.
Sep 6 2017, 3:08 PM
marieheleneka_gmail.com added a comment to D12238: Implement random modulus with kern.randompid=1.
In D12238#254056, @des wrote:

BTW, 100 is a reasonable lower bound, but perhaps pid_max - 100 would be a better upper bound than 999, since it is already the maximum for an explicitly selected value.

Sep 6 2017, 3:04 PM
marieheleneka_gmail.com updated the summary of D12238: Implement random modulus with kern.randompid=1.
Sep 6 2017, 8:04 AM
marieheleneka_gmail.com added a comment to D12238: Implement random modulus with kern.randompid=1.

This patch doesn't implement PID randomization; that's already in. This patch just makes the sysctl value "1" generate a random modulus, instead of leaving the feature disabled.

Sep 6 2017, 8:01 AM

Sep 5 2017

marieheleneka_gmail.com added a comment to D12238: Implement random modulus with kern.randompid=1.

Want feedback on: Is the number range 100-999 sane?

Sep 5 2017, 11:56 PM
marieheleneka_gmail.com updated the test plan for D12238: Implement random modulus with kern.randompid=1.
Sep 5 2017, 11:23 PM
marieheleneka_gmail.com updated the summary of D12238: Implement random modulus with kern.randompid=1.
Sep 5 2017, 11:22 PM
marieheleneka_gmail.com created D12238: Implement random modulus with kern.randompid=1.
Sep 5 2017, 11:19 PM

Apr 1 2017

marieheleneka_gmail.com updated the diff for D10225: libifconfig: Can now create some interfaces. Various bug fixes.

This diff now also includes changes to examples, and new examples.

Apr 1 2017, 8:17 AM

Mar 31 2017

marieheleneka_gmail.com updated the summary of D10225: libifconfig: Can now create some interfaces. Various bug fixes.
Mar 31 2017, 4:30 PM
marieheleneka_gmail.com created D10225: libifconfig: Can now create some interfaces. Various bug fixes.
Mar 31 2017, 4:24 PM

Sep 4 2016

marieheleneka_gmail.com added inline comments to D7764: libifconfig: style(9) and license fixes.
Sep 4 2016, 4:56 PM
marieheleneka_gmail.com updated the diff for D7764: libifconfig: style(9) and license fixes.

Fixed missing line, and ordered includes properly in libifconfig_internal.c.

Sep 4 2016, 4:19 PM
marieheleneka_gmail.com updated the diff for D7764: libifconfig: style(9) and license fixes.

Fixed another nit that got broken in previous fix. :)

Sep 4 2016, 4:15 PM
marieheleneka_gmail.com updated the diff for D7764: libifconfig: style(9) and license fixes.

Fixed minor nit, and fixed up examples as well.

Sep 4 2016, 1:43 PM

Sep 2 2016

marieheleneka_gmail.com retitled D7764: libifconfig: style(9) and license fixes from to libifconfig: style(9) and license fixes.
Sep 2 2016, 8:27 PM

Sep 1 2016

marieheleneka_gmail.com added a comment to D7742: Rename libifc back to libifconfig.

danfe: Thanks for the feedback on style(9). I will address it in the upcoming style(9) fix, no need to submit the feedback again. :)

Sep 1 2016, 3:27 PM
marieheleneka_gmail.com updated the diff for D7742: Rename libifc back to libifconfig.

Patch now applies against lib/libifc and share/examples/libifc instead of attempting to move the files.
Before commit, please use 'svn mv' as follows to rename things properly:

Sep 1 2016, 3:26 PM
marieheleneka_gmail.com retitled D7742: Rename libifc back to libifconfig from to Rename libifc back to libifconfig.
Sep 1 2016, 1:40 PM

Aug 25 2016

marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

Added missing $FreeBSD$ tags

Aug 25 2016, 7:20 PM

Aug 24 2016

marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

Now tells lib/Makefile to build libifc, so it actually gets built with 'buildworld'
Disabled building of shared library for now, to further state this is not production ready.

Aug 24 2016, 11:46 AM

Aug 18 2016

marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

Removed libifc_ioctlwrap_caddrt as it was not necessary.
'struct ifreq ifr' is now always initialized by overwriting it with 0's.
Makefile now defines WARN?=6 to fault on all warnings. (Warnings are future "gifts" we don't want)

Aug 18 2016, 12:55 PM

Aug 17 2016

marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

Fixed a few missed renames.

Aug 17 2016, 3:33 PM
marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

The only change in this revision is the library has been renamed from "libifconfig" to "libifc", to be in sync with the prefixes and what people are actually calling it. Uploading it so it will be easier to track changes between revisions here.

Aug 17 2016, 3:10 PM
marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

Addressed comments.

Aug 17 2016, 11:01 AM
marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

Addressed feedback.

Aug 17 2016, 9:54 AM

Aug 16 2016

marieheleneka_gmail.com added inline comments to D7529: libifconfig: First baby steps towards libification of ifconfig.
Aug 16 2016, 3:47 PM
marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

Addressed feedback

Aug 16 2016, 3:20 PM
marieheleneka_gmail.com updated the diff for D7529: libifconfig: First baby steps towards libification of ifconfig.

Removed things that are not related to FreeBSD base.

Aug 16 2016, 1:07 PM
marieheleneka_gmail.com retitled D7529: libifconfig: First baby steps towards libification of ifconfig from to libifconfig: First baby steps towards libification of ifconfig.
Aug 16 2016, 12:54 PM

Apr 14 2016

marieheleneka_gmail.com updated the diff for D5336: Add missing descriptions in sysctl net.inet6 namespace.

Simplified language as suggested by reviewers

Apr 14 2016, 8:23 AM

Mar 1 2016

marieheleneka_gmail.com updated the diff for D5336: Add missing descriptions in sysctl net.inet6 namespace.

sysctl MIB descriptions now end without punctuation, to be in line with how this is generally done. Also removed ending period of some existing descriptions.

Mar 1 2016, 12:39 PM

Feb 24 2016

marieheleneka_gmail.com added a comment to D5336: Add missing descriptions in sysctl net.inet6 namespace.

Please do not commit this yet. Out of a couple thousand sysctl's, only about 130 had a description ending with a period. Although I did not filter out the ones without a description, I still think this is telling.

Feb 24 2016, 3:28 PM

Feb 19 2016

marieheleneka_gmail.com added inline comments to D5336: Add missing descriptions in sysctl net.inet6 namespace.
Feb 19 2016, 11:29 PM
marieheleneka_gmail.com updated the diff for D5341: ifconfig(8): bug: can't use 'name' or 'description' when creating interface with auto numbering.

Addressed inline comments.

Feb 19 2016, 9:57 PM
marieheleneka_gmail.com added a comment to D5341: ifconfig(8): bug: can't use 'name' or 'description' when creating interface with auto numbering.

in ifconfig.c, the function setifmetric(...) use "sizeof (ifr.ifr_name)", while the function ifconfig(...) line795 and 812 use "sizeof ifr.ifr_name".

Feb 19 2016, 9:13 PM
marieheleneka_gmail.com updated the diff for D5336: Add missing descriptions in sysctl net.inet6 namespace.

Updated revision addressing inline comments.
Moved Warren Block and Ed Maste from Subscribers to Reviewers.

Feb 19 2016, 8:00 PM
marieheleneka_gmail.com added a reviewer for D3583: Document sysctl MIBs in sctp(4): wblock.
Feb 19 2016, 7:14 PM
marieheleneka_gmail.com added reviewers for D5341: ifconfig(8): bug: can't use 'name' or 'description' when creating interface with auto numbering: gnn, kristof.
Feb 19 2016, 5:13 PM
marieheleneka_gmail.com updated the diff for D5341: ifconfig(8): bug: can't use 'name' or 'description' when creating interface with auto numbering.

Updated revision to have proper context

Feb 19 2016, 5:44 AM
marieheleneka_gmail.com updated the diff for D5341: ifconfig(8): bug: can't use 'name' or 'description' when creating interface with auto numbering.

Renamed 'echoifname' to 'printifname' to be more consistent.
New behaviour: The 'name' command will now trigger printing of new interface name if the rename is successful. Example: "ifconfig tap0 name blah" will echo "blah" on success, and not echo anything on failure.

Feb 19 2016, 4:25 AM
marieheleneka_gmail.com retitled D5341: ifconfig(8): bug: can't use 'name' or 'description' when creating interface with auto numbering from to ifconfig(8): bug: can't use 'name' or 'description' when creating interface with auto numbering.
Feb 19 2016, 3:06 AM

Feb 18 2016

marieheleneka_gmail.com updated subscribers of D5336: Add missing descriptions in sysctl net.inet6 namespace.
Feb 18 2016, 11:41 PM
marieheleneka_gmail.com retitled D5336: Add missing descriptions in sysctl net.inet6 namespace from to Add missing descriptions in sysctl net.inet6 namespace.
Feb 18 2016, 11:29 PM
marieheleneka_gmail.com updated the diff for D3583: Document sysctl MIBs in sctp(4).

I'm submitting this revision to have the current state of the work on this in the review. I've researched and documented more MIBs, grouped under the 'Congestion Control' sub-header. The MIBs listed under the Misc sub-header have not been updated yet. MIB names will be formatted with underline to match the TCP(4) man page. MIBs will gain the underline formatting as their descriptions are updated or considered OK.

Feb 18 2016, 10:03 PM

Sep 9 2015

marieheleneka_gmail.com added a comment to D3583: Document sysctl MIBs in sctp(4).

I'm sorry about not including context; will do that with next revision.

Sep 9 2015, 3:14 AM

Sep 7 2015

marieheleneka_gmail.com retitled D3583: Document sysctl MIBs in sctp(4) from to Document sysctl MIBs in sctp(4).
Sep 7 2015, 8:42 AM

Sep 6 2015

marieheleneka_gmail.com updated the diff for D3528: Document the sctp blackhole sysctl MIB.

The SCTP subsection felt awkward, so I've reworded it to flow better for the reader.

Sep 6 2015, 8:31 PM
marieheleneka_gmail.com updated the diff for D3528: Document the sctp blackhole sysctl MIB.

Corrected synopsis to state the sctp.blackhole MIB has valid values of 0, 1 and 2.

Sep 6 2015, 5:47 PM
marieheleneka_gmail.com updated the diff for D3528: Document the sctp blackhole sysctl MIB.

Fixed a stray space in synopsis Brq parameter.

Sep 6 2015, 5:24 PM
marieheleneka_gmail.com updated the diff for D3528: Document the sctp blackhole sysctl MIB.

Improved formatting of synopsis according to wblock's feedback.
Added subsections to the DESCRIPTION section for SCTP, TCP, and UDP
Moved the SCTP subsection to the top, so that the subsections are sorted alphabetically
Phrases which list SCTP, TCP, and UDP together are now consistent in listing them alphabetically
Moved the 'summary' paragraph from the bottom of DESCRIPTION to directly before the first subsection.

Sep 6 2015, 5:20 PM

Sep 5 2015

marieheleneka_gmail.com updated the diff for D3528: Document the sctp blackhole sysctl MIB.

Updated to address feedback from wblock.

Sep 5 2015, 10:03 PM
marieheleneka_gmail.com commandeered D3528: Document the sctp blackhole sysctl MIB.
Sep 5 2015, 10:01 PM