- User Since
- Aug 29 2015, 6:06 PM (181 w, 6 d)
Mon, Feb 11
Jan 14 2019
Patch has been widthdrawn as lang/phantomjs doesn't build on 12/13, and phantomjs is no longer maintained (see: https://github.com/ariya/phantomjs/issues/15344). The fork (https://github.com/vitallium/phantomjs/) used by this port seems abandoned as well.
Missed some changes in the files/ directory. Testing the created patch before updating.
Dec 29 2018
Made code a bit more readable by storing jid as a variable, instead of double ?: syntax.
Fixed trailing whitespace.
Dec 20 2018
Added jid to log message for sigexit as well.
Made formatting more consistent (removed a colon)
Nov 28 2018
Nov 27 2018
Reminder to whomever commits this: PORTREVISION is a moving target and should be updated properly when committing.
Looks good to me.
I added port maintainer (Marius Halden) to reviewers list as well.
Oct 13 2018
Some minor corrections. Turns out it helps if I run tests on the right tree. :)
More trailing whitespace
Update according to feedback
Oct 11 2018
Sep 20 2018
I've not cycled back to this diff, and probably won't get to do the research necessary to document the remaining MIBs. Can this revision be committed as-is?
Closing this revision, apparently one already exists from a year ago. D12476
Jun 19 2018
This was superseded by/included in rS329853
Oct 4 2017
Was committed in rS323390. (This comment is only to close the revision)
Sep 27 2017
Just adding that I've run the test procedure by creating a custom installation media and installing to a VM. Ticking the PID randomization checkbox works as intended.
Sep 21 2017
It builds on the previous work committed in rS323390, yes.
Sep 10 2017
Since the upper bound of modulus was picked somewhat randomly, change it so the math is simpler. (suggested by des@)
Fixed bug introduced in previous revision: setting kern.randompid=0 sets it to 100
Restructured if-then-else tree to make slightly more sense while here. (feedback from des@)
Sep 8 2017
Implement random modulus with kern.randompid=1
Fixed some incorrect assumptions (casting+abs()) and using cross-cast instead of modulus for more randomized results.
Sep 6 2017
This patch doesn't implement PID randomization; that's already in. This patch just makes the sysctl value "1" generate a random modulus, instead of leaving the feature disabled.
Sep 5 2017
Want feedback on: Is the number range 100-999 sane?
Apr 1 2017
This diff now also includes changes to examples, and new examples.
Mar 31 2017
Sep 4 2016
Fixed missing line, and ordered includes properly in libifconfig_internal.c.
Fixed another nit that got broken in previous fix. :)
Fixed minor nit, and fixed up examples as well.
Sep 2 2016
Sep 1 2016
danfe: Thanks for the feedback on style(9). I will address it in the upcoming style(9) fix, no need to submit the feedback again. :)
Patch now applies against lib/libifc and share/examples/libifc instead of attempting to move the files.
Before commit, please use 'svn mv' as follows to rename things properly:
Aug 25 2016
Added missing $FreeBSD$ tags
Aug 24 2016
Now tells lib/Makefile to build libifc, so it actually gets built with 'buildworld'
Disabled building of shared library for now, to further state this is not production ready.
Aug 18 2016
Removed libifc_ioctlwrap_caddrt as it was not necessary.
'struct ifreq ifr' is now always initialized by overwriting it with 0's.
Makefile now defines WARN?=6 to fault on all warnings. (Warnings are future "gifts" we don't want)
Aug 17 2016
Fixed a few missed renames.
The only change in this revision is the library has been renamed from "libifconfig" to "libifc", to be in sync with the prefixes and what people are actually calling it. Uploading it so it will be easier to track changes between revisions here.
Aug 16 2016
Removed things that are not related to FreeBSD base.
Apr 14 2016
Simplified language as suggested by reviewers
Mar 1 2016
sysctl MIB descriptions now end without punctuation, to be in line with how this is generally done. Also removed ending period of some existing descriptions.
Feb 24 2016
Please do not commit this yet. Out of a couple thousand sysctl's, only about 130 had a description ending with a period. Although I did not filter out the ones without a description, I still think this is telling.
Feb 19 2016
Addressed inline comments.
in ifconfig.c, the function setifmetric(...) use "sizeof (ifr.ifr_name)", while the function ifconfig(...) line795 and 812 use "sizeof ifr.ifr_name".
Updated revision addressing inline comments.
Moved Warren Block and Ed Maste from Subscribers to Reviewers.
Updated revision to have proper context
Renamed 'echoifname' to 'printifname' to be more consistent.
New behaviour: The 'name' command will now trigger printing of new interface name if the rename is successful. Example: "ifconfig tap0 name blah" will echo "blah" on success, and not echo anything on failure.
Feb 18 2016
I'm submitting this revision to have the current state of the work on this in the review. I've researched and documented more MIBs, grouped under the 'Congestion Control' sub-header. The MIBs listed under the Misc sub-header have not been updated yet. MIB names will be formatted with underline to match the TCP(4) man page. MIBs will gain the underline formatting as their descriptions are updated or considered OK.
Sep 9 2015
I'm sorry about not including context; will do that with next revision.
Sep 7 2015
Sep 6 2015
The SCTP subsection felt awkward, so I've reworded it to flow better for the reader.
Corrected synopsis to state the sctp.blackhole MIB has valid values of 0, 1 and 2.
Fixed a stray space in synopsis Brq parameter.
Improved formatting of synopsis according to wblock's feedback.
Added subsections to the DESCRIPTION section for SCTP, TCP, and UDP
Moved the SCTP subsection to the top, so that the subsections are sorted alphabetically
Phrases which list SCTP, TCP, and UDP together are now consistent in listing them alphabetically
Moved the 'summary' paragraph from the bottom of DESCRIPTION to directly before the first subsection.
Sep 5 2015
Updated to address feedback from wblock.