Page MenuHomeFreeBSD

Rename www/mod_security3 to www/modsecurity3.
ClosedPublic

Authored by des on Nov 27 2018, 7:10 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

des created this revision.Nov 27 2018, 7:10 AM
joneum added a subscriber: joneum.Nov 27 2018, 8:06 AM
joneum added inline comments.
security/modsecurity3/Makefile
37 ↗(On Diff #51154)

what you exactly mean whit "??"

joneum added inline comments.Nov 27 2018, 8:10 AM
security/modsecurity3/Makefile
13 ↗(On Diff #51154)

There is a LICENSE File inside. Pls add "LICENSE_FILE"

des marked 4 inline comments as done.Nov 27 2018, 8:28 AM
des added inline comments.
security/modsecurity3/Makefile
13 ↗(On Diff #51154)

This will be handled by the maintainer in the upcoming upgrade to 3.0.3.

37 ↗(On Diff #51154)

Looks good to me.
I added port maintainer (Marius Halden) to reviewers list as well.

This revision is now accepted and ready to land.Nov 27 2018, 8:34 AM
des marked 2 inline comments as done.Nov 27 2018, 8:43 AM
des updated this revision to Diff 51156.EditedNov 27 2018, 8:51 AM

Fix date in MOVED and add www/nginx PORTREVISION bump that fell out when I generated the diff.

This revision now requires review to proceed.Nov 27 2018, 8:51 AM
joneum added inline comments.Nov 27 2018, 8:58 AM
security/modsecurity3/Makefile
37 ↗(On Diff #51154)

I can not find anything under this link. What exactly does "??" here?

des removed a subscriber: joneum.Nov 27 2018, 9:08 AM
joneum added a subscriber: joneum.Nov 27 2018, 9:14 AM
security/modsecurity3/Makefile
20 ↗(On Diff #51156)

Why was uses gnome added?

Just ignore my previous question, it's because of libxml2. Looks good to me.

This revision is now accepted and ready to land.Nov 27 2018, 10:01 AM
This revision was automatically updated to reflect the committed changes.