Page MenuHomeFreeBSD
Differential D18039

USES=cargo to convert LDFLAGS into RUSTFLAGS
ClosedPublic
Actions

Authored by jbeich on Nov 18 2018, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 1:54 PM
Unknown Object (File)
Tue, Apr 9, 4:25 PM
Unknown Object (File)
Mon, Apr 1, 7:17 PM
Unknown Object (File)
Mon, Apr 1, 7:17 PM
Unknown Object (File)
Mon, Apr 1, 7:17 PM
Unknown Object (File)
Mon, Apr 1, 7:17 PM
Unknown Object (File)
Mon, Apr 1, 7:08 PM
Unknown Object (File)
Thu, Mar 28, 2:00 PM
View All 50 Files
Subscribers
None

Details

Reviewers
None
Group Reviewers
rust
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP486769: USES=cargo to convert LDFLAGS into RUSTFLAGS
Summary

No consumers appear to require LDFLAGS at this time as only -fstack-protector is passed by default.

Test Plan

All consumers built fine (tested together with D18427).

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21357
Build 20684: arc lint + arc unit

Event Timeline

jbeich created this revision.Nov 18 2018, 8:25 PM
Harbormaster completed remote builds in B20879: Diff 50569.Nov 18 2018, 8:25 PM
jbeich added inline comments.Nov 18 2018, 8:28 PM
Mk/Uses/cargo.mk
71

Should -C link-arg=* be before or after RUSTFLAGS (from environment or set by port)?

tobik requested changes to this revision.Nov 22 2018, 5:05 AM
tobik added inline comments.
Mk/Uses/cargo.mk
71

What does the extra : at the end do?

Should -C link-arg=* be before or after RUSTFLAGS (from environment or set by port)?

I don't think the order matters much since no port sets any -C link-arg in RUSTFLAGS. With this in place ports should manipulate LDFLAGS over RUSTFLAGS anyway.

This revision now requires changes to proceed.Nov 22 2018, 5:05 AM
tobik accepted this revision.Nov 22 2018, 5:06 AM

Oops, meant to accept (if you remove the extra :).

This revision is now accepted and ready to land.Nov 22 2018, 5:06 AM
jbeich updated this revision to Diff 51578.Dec 4 2018, 2:10 PM
jbeich edited the test plan for this revision. (Show Details)
jbeich edited reviewers, added: rust; removed: tobik, dumbbell, riggs, koobs, will.
  • Drop spurious : (colon) as requested by @tobik
This revision now requires review to proceed.Dec 4 2018, 2:10 PM
Harbormaster completed remote builds in B21357: Diff 51578.Dec 4 2018, 2:11 PM
tobik accepted this revision as: rust.Dec 4 2018, 7:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2018, 5:08 PM
Closed by commit rP486769: USES=cargo to convert LDFLAGS into RUSTFLAGS (authored by jbeich). · Explain Why
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: O5: Ports Framework.Dec 6 2018, 5:08 PM
Herald added a reviewer: portmgr. · View Herald TranscriptDec 6 2018, 5:08 PM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
4 lines

Diff 51578

View Options

Mk/Uses/cargo.mk

Loading...