Page MenuHomeFreeBSD
Differential D17967

Capsicumize brandelf.
ClosedPublic
Actions

Authored by oshogbo on Nov 12 2018, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:39 AM
Unknown Object (File)
Nov 11 2023, 3:34 AM
Unknown Object (File)
Nov 9 2023, 3:35 AM
Unknown Object (File)
Oct 8 2023, 2:32 AM
Unknown Object (File)
Feb 27 2023, 3:56 PM
Subscribers
jonathan

Details

Reviewers
cem
allanjude
emaste
markj

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

oshogbo created this revision.Nov 12 2018, 9:39 PM
Herald added a subscriber: jonathan. · View Herald TranscriptNov 12 2018, 9:39 PM
allanjude accepted this revision.Nov 12 2018, 11:36 PM
This revision is now accepted and ready to land.Nov 12 2018, 11:36 PM
markj accepted this revision.Nov 13 2018, 12:57 AM
markj added inline comments.
usr.bin/brandelf/Makefile
10

Inconsistent whitespace.

usr.bin/brandelf/brandelf.c
141

These should really have separate error messages.

emaste added inline comments.Nov 13 2018, 1:01 AM
usr.bin/brandelf/brandelf.c
141

I'm indifferent on that - is there a different action the user can take based on which error message comes out?

markj added inline comments.Nov 13 2018, 1:09 AM
usr.bin/brandelf/brandelf.c
141

No, but the first step taken by anyone debugging the error will be to figure out which of the two calls is failing.

emaste added inline comments.Nov 13 2018, 2:15 AM
usr.bin/brandelf/brandelf.c
141

Most likely the first action is to set kern.trap_enotcap to 1 and get a backtrace? Anyway I'm fine with either.

oshogbo closed this revision.Nov 18 2018, 12:25 PM

r340572

Revision Contents
Changeset List

PathSize
usr.bin/
brandelf/
8 lines
25 lines

Diff 50343

View Options

usr.bin/brandelf/Makefile

Loading...
View Options

usr.bin/brandelf/brandelf.c

Loading...