mips dts modify
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20759 Build 20160: arc lint + arc unit
Event Timeline
Why was MZK-W04N-XX.dts moved to sys/dts instead of sys/gnu/dts ?
Also, I see (I looked at rt3883.dtsi specifically, but I assume there may be others as well) that you haven't included the proper '#include "fbsd-rt3883.dtsi"' at the end of the imported base dtsi files.
Please fix that or explain why it is not necessary. Please have a look at: https://reviews.freebsd.org/D6394 for more details on which dtsi files need to be modified like this.
Please address the above before moving forward with the commit.
My understand is sys/gnu/dts have only openwrt(opneled) dts files. And sys/dts have freebsd original dts files. MZK-W04N-XX.dts is my missing add dts file then move to freebsd dts directory. Do you think how to sync openwrt(opneled) dts files ?
I am saying that for now, before importing from OpenWRT, you should add:
- at the end of rt3883.dtsi: #include "fbsd-mt7621.dtsi"
- at the end of mt7620a.dtsi: #include "fbsd-mt7620a.dtsi"
- at the end of mt7621.dtsi: #include "fbsd-mt7621.dtsi"
- at the end of mt7628.dtsi: #include "fbsd-mt7628.dtsi"
Otherwise some functionalities (e.g., GPIO, PCIe) will be broken for these platforms.
I have been thinking about fully supporting the OpenWRT dts/dtsi for a while now, but unfortunately I can't find the time to do it lately.