Page MenuHomeFreeBSD
Differential D17955

mips dts modify
AbandonedPublic
Actions

Authored by yamori813_yahoo.co.jp on Nov 11 2018, 11:00 PM.
Tags
None
Referenced Files
F105802064: D17955.diff
Fri, Dec 20, 9:53 PM
Unknown Object (File)
Thu, Dec 19, 1:26 AM
Unknown Object (File)
Tue, Dec 10, 4:05 AM
Unknown Object (File)
Nov 17 2024, 6:23 AM
Unknown Object (File)
Nov 14 2024, 9:20 AM
Unknown Object (File)
Oct 20 2024, 2:31 AM
Unknown Object (File)
Oct 5 2024, 3:32 PM
Unknown Object (File)
Oct 5 2024, 8:45 AM
View All 85 Files
Subscribers
None

Details

Reviewers
sgalabov
adrian
mizhka
hrs
manu
Summary

mips dts modify

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20758
Build 20159: arc lint + arc unit

Event Timeline

yamori813_yahoo.co.jp created this revision.Nov 11 2018, 11:00 PM
Herald added a reviewer: manu. · View Herald TranscriptNov 11 2018, 11:00 PM
Harbormaster completed remote builds in B20758: Diff 50295.Nov 11 2018, 11:00 PM
yamori813_yahoo.co.jp updated this revision to Diff 50296.Nov 11 2018, 11:05 PM
  • upgrade dts file at openwrt v18.06.1
Harbormaster completed remote builds in B20759: Diff 50296.Nov 11 2018, 11:05 PM
yamori813_yahoo.co.jp removed a reviewer: manu.Nov 11 2018, 11:11 PM
Herald added a reviewer: manu. · View Herald TranscriptNov 11 2018, 11:11 PM
yamori813_yahoo.co.jp added reviewers: sgalabov, adrian, mizhka, hrs.Nov 11 2018, 11:12 PM
manu resigned from this revision.Nov 12 2018, 4:47 PM
mizhka accepted this revision.Mar 21 2019, 7:11 AM
This revision is now accepted and ready to land.Mar 21 2019, 7:11 AM
sgalabov requested changes to this revision.Mar 21 2019, 9:54 AM

Why was MZK-W04N-XX.dts moved to sys/dts instead of sys/gnu/dts ?

Also, I see (I looked at rt3883.dtsi specifically, but I assume there may be others as well) that you haven't included the proper '#include "fbsd-rt3883.dtsi"' at the end of the imported base dtsi files.
Please fix that or explain why it is not necessary. Please have a look at: https://reviews.freebsd.org/D6394 for more details on which dtsi files need to be modified like this.

Please address the above before moving forward with the commit.

This revision now requires changes to proceed.Mar 21 2019, 9:54 AM
yamori813_yahoo.co.jp added a comment.Mar 22 2019, 7:11 AM

My understand is sys/gnu/dts have only openwrt(opneled) dts files. And sys/dts have freebsd original dts files. MZK-W04N-XX.dts is my missing add dts file then move to freebsd dts directory. Do you think how to sync openwrt(opneled) dts files ?

sgalabov added a comment.Mar 22 2019, 8:00 AM
In D17955#421328, @yamori813_yahoo.co.jp wrote:

My understand is sys/gnu/dts have only openwrt(opneled) dts files. And sys/dts have freebsd original dts files. MZK-W04N-XX.dts is my missing add dts file then move to freebsd dts directory. Do you think how to sync openwrt(opneled) dts files ?

I am saying that for now, before importing from OpenWRT, you should add:

  • at the end of rt3883.dtsi: #include "fbsd-mt7621.dtsi"
  • at the end of mt7620a.dtsi: #include "fbsd-mt7620a.dtsi"
  • at the end of mt7621.dtsi: #include "fbsd-mt7621.dtsi"
  • at the end of mt7628.dtsi: #include "fbsd-mt7628.dtsi"

Otherwise some functionalities (e.g., GPIO, PCIe) will be broken for these platforms.
I have been thinking about fully supporting the OpenWRT dts/dtsi for a while now, but unfortunately I can't find the time to do it lately.

yamori813_yahoo.co.jp abandoned this revision.Mar 22 2019, 8:37 AM

OK. I copy only my repository that is I want use.

Revision Contents
Changeset List

PathSize
sys/
dts/
mips/
gnu/
dts/
mips/
94 lines
gnu/
dts/
mips/

Diff 50295

View Options

sys/dts/mips/MZK-W04N-XX.dts

Loading...
View Options

sys/gnu/dts/mips/MZK-W04N-XX.dts

Loading...