Fix a number of bugs in freebsd32's capabilities.conf.
ClosedPublic
Actions

Authored by brooks on Nov 9 2018, 5:13 PM.

Details

Reviewers

emaste
kib
oshogbo

Commits

rS340379: Regen after r340377: MFC r340272, r340274, r340294
rS340378: MFC r340272, r340274, r340294
rS340295: Regen after r340294: Fix a number of bugs in freebsd32's capabilities.conf.
rS340294: Fix a number of bugs in freebsd32's capabilities.conf.

Summary

Bugs range from failure to update after changing syscall implementaion
names to using the wrong name. Somewhat confusingly, the name in
capabilities.conf is exactly the string that appears in syscalls.master,
not the name with a COMPAT* prefix.

Found while making a change to use the default capabilities.conf.

Fixes: r335177, r336980, r340272, r340274, others

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20722
Build 20133: arc lint + arc unit

Event Timeline

brooks created this revision.Nov 9 2018, 5:13 PM

Harbormaster completed remote builds in B20722: Diff 50218.Nov 9 2018, 5:13 PM

brooks marked an inline comment as done.Nov 9 2018, 5:16 PM

brooks added inline comments.

sys/compat/freebsd32/capabilities.conf
105	Note that this exposes a separate bug that there isn't a freebsd32_ommap.

I'm not able to usefully review them all, but the change overall looks sensible.

This revision is now accepted and ready to land.Nov 9 2018, 5:25 PM

kib accepted this revision.Nov 9 2018, 5:27 PM

Closed by commit rS340294: Fix a number of bugs in freebsd32's capabilities.conf. (authored by brooks). · Explain WhyNov 9 2018, 6:03 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 9 2018, 6:03 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

freebsd32/

capabilities.conf

39 lines

Diff 50218

View Options

sys/compat/freebsd32/capabilities.conf

Fix a number of bugs in freebsd32's capabilities.conf.ClosedPublicActions