Rebase one Makefile patch and patch new use of mremap with munmap+mmap.
cem on Nov 4 2018, 3:48 AM.Authored by
This looks good to me, thanks (with the disclaimer that I'm not exactly an expert on the mmap stuff).
I checked the man page for mrep on an openSUSE system and found
CONFORMING TO This call is Linux-specific, and should not be used in programs intended to be portable.
so indeed the looks like a (portability) bug. Are you going to report this upstream (possibly with your patch) or would you like me to do so?
Thanks! I'm not either. Just doing my best off reading the manual pages. I have some concerns with my approach as taken but don't like anything else much better.
My impression is that elfutils is by Linux folks for Linux exclusively. They don't mind that we port it, but I don't think they care much about off-Linux portability. If you would like to send the report upstream, please go ahead. But I am not very optimistic. There is a bunch of other Linux-specific functionality we port around if you check out the rest of the patches in files/. In particular, patch-lib_eu-config.h. (Maybe mremap should have been added as a static inline there instead.)
Thanks for reviewing!