Page MenuHomeFreeBSD

Cosmetic changes to try to inline the memset with SSE/AVX instructions.
ClosedPublic

Authored by araujo on Nov 1 2018, 8:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 6:16 AM
Unknown Object (File)
Sun, Oct 5, 2:24 AM
Unknown Object (File)
Tue, Sep 30, 12:47 PM
Unknown Object (File)
Sun, Sep 28, 12:01 AM
Unknown Object (File)
Thu, Sep 25, 11:56 AM
Unknown Object (File)
Sat, Sep 20, 12:58 AM
Unknown Object (File)
Sep 13 2025, 1:39 PM
Unknown Object (File)
Sep 13 2025, 6:02 AM
Subscribers

Details

Summary

This topic was discussed on review D17759.

Test Plan

Linux Guest with disk nvme ram.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks added inline comments.
usr.sbin/bhyve/pci_nvme.c
257 ↗(On Diff #49865)

@jhb's suggestion was that this should become:

memset(dst, pad, dist_size);

Address the memset according with the suggestion made by @jhb.

araujo marked an inline comment as done.
araujo added inline comments.
usr.sbin/bhyve/pci_nvme.c
257 ↗(On Diff #49865)

Yes, thank you! I read that wrong, sorry about the noise.

Commit message should mention the switch to size_t.

usr.sbin/bhyve/pci_nvme.c
256 ↗(On Diff #49920)

Style(9) would have you do put a blank line after decelerations and do the assignment on a separate line.

This revision is now accepted and ready to land.Nov 5 2018, 5:32 PM
This revision was automatically updated to reflect the committed changes.