Page MenuHomeFreeBSD
Differential D1767

Refragment packets after defragmenting them in PF
ClosedPublic
Actions

Authored by kp on Feb 3 2015, 8:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 13, 3:56 PM
Unknown Object (File)
Dec 4 2024, 7:58 AM
Unknown Object (File)
Dec 4 2024, 7:58 AM
Unknown Object (File)
Dec 4 2024, 7:58 AM
Unknown Object (File)
Nov 25 2024, 11:13 AM
Unknown Object (File)
Nov 25 2024, 11:13 AM
Unknown Object (File)
Nov 25 2024, 11:13 AM
Unknown Object (File)
Nov 25 2024, 11:13 AM
View All Files
Subscribers
ae
allanjude
glebius
network

Details

Reviewers
glebius
Summary

In the forwarding case refragment the reassembled packets with the same
size as they arrived in. This allows the sender to determine the optimal
fragment size by Path MTU Discovery.

Roughly based on the OpenBSD work by Alexander Bluhm.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kp updated this revision to Diff 3621.Feb 3 2015, 8:08 PM
kp retitled this revision from to Refragment packets after defragmenting them in PF.
kp updated this object.
kp edited the test plan for this revision. (Show Details)
kp added parent revisions: D1765: PF: Handle fragmented IPv6 packets, D1764: Factor out ip6_deletefraghdr().
kp added a subscriber: Unknown Object (MLST).Feb 3 2015, 8:53 PM
kp updated this revision to Diff 3714.Feb 9 2015, 11:20 PM
kp added a parent revision: D1815: Evaluate packet size after the firewall had its chance.
ae edited subscribers, added: network; removed: Unknown Object (MLST).Feb 10 2015, 9:16 AM
ae added a subscriber: ae.Feb 10 2015, 9:59 AM
ae added inline comments.
sys/netpfil/pf/pf_norm.c
1138

ip6_fragment() seems OpenBSD's function, we haven't it.

1156

Where should be initialized this variable?

ae added inline comments.Feb 10 2015, 10:04 AM
sys/netpfil/pf/pf_norm.c
1138

Ok, looks like you have many patches in phabricator.

glebius accepted this revision.Feb 12 2015, 9:05 PM
glebius added a reviewer: glebius.
glebius added a subscriber: glebius.

If it tested properly and fixes the problems that Peter Wemm experiences with the cluster, please check it in. Thanks a lot.

sys/netpfil/pf/pf_norm.c
1118

Use KASSERT here please.

1119

Use char * instead of caddr_t, please.

This revision is now accepted and ready to land.Feb 12 2015, 9:05 PM
kp updated this revision to Diff 3765.Feb 14 2015, 2:11 PM
kp edited edge metadata.
This revision now requires review to proceed.Feb 14 2015, 2:11 PM
glebius accepted this revision.Feb 16 2015, 6:59 AM
glebius edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2015, 6:59 AM
kp closed this revision.Feb 16 2015, 7:01 AM

Submitted as r278843 - head/sys/netpfil/pf

allanjude added a subscriber: allanjude.Feb 24 2015, 1:20 AM

I am seeing a crash that looks like it might be related to this: https://lists.freebsd.org/pipermail/freebsd-current/2015-February/054707.html

Revision Contents
Changeset List

PathSize
sys/
net/
1 line
netpfil/
pf/
2 lines
13 lines
1 line
81 lines

Diff 3765

View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf.h

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_mtag.h

Loading...
View Options

sys/netpfil/pf/pf_norm.c

Loading...