Page MenuHomeFreeBSD

Deprecate a number of less used 10 and 10/100 Ethernet devices.
ClosedPublic

Authored by brooks on Oct 22 2018, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 2:35 PM
Unknown Object (File)
Jan 13 2024, 11:14 AM
Unknown Object (File)
Dec 20 2023, 3:22 AM
Unknown Object (File)
Dec 17 2023, 3:24 AM
Unknown Object (File)
Nov 11 2023, 3:12 AM
Unknown Object (File)
Sep 27 2023, 10:33 PM
Unknown Object (File)
Sep 12 2023, 4:51 PM
Unknown Object (File)
Jun 3 2023, 1:56 AM
Subscribers

Details

Summary
NOTE: this review is preceeding in parallel with the core vote on FCP-0101.

The current deprecated list is: ae, bm, cs, de, dme, ed, ep, ex, fe,
pcn, sf, sn, tl, tx, txp, vx, wb, xe

The list as refined as part of FCP-0101. Per the FCP, devices may be
removed from the deprecation list if enough users are found or they are
converted to iflib.

FCP: https://github.com/freebsd/fcp/blob/master/fcp-0101.md

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20364
Build 19805: arc lint + arc unit

Event Timeline

Does it make any sense at all to #define a macro gone_by_fcp101?

sys/dev/wb/if_wb.c
699

These need a post approved resting home in an address ending in freebsd.org. We do not need to start externalizing data from our repository outside.

Does it make any sense at all to #define a macro gone_by_fcp101?

That's not a terrible idea, but I don't see the value in re-editing all these files to use one.

sys/dev/wb/if_wb.c
699

I do think an fcp.freebsd.org that does redirects to https://github.com/freebsd/fcp/blob/master/ would do it. There is no value in hosting this git repo or adding a manual publishing step.

My last comments where too aggressive. Blame a replying early in the morning and feeling rushed by your request to have this in for Thursday's build.

I don't have time or ability to build an fcp.freebsd.org and it's not clear there's an easy way to make a simple URL redirector work. I think it wouldn't be hard to build something the published accepted FCPs automatically.

I'll point out that https://github.com/freebsd is under FreeBSD Project control, for the most part. It's a risk, but this code likely has a limited enough time horizon to accept that limitation until someone can create a fcp.freebsd.org redirector.

Eg, it's not important enough to gate this commit for that.

One of the reasons for me asking to "macrotise" this is that we can commit it today with a poor URL in it, and very easily correct that URL some time soon(ish),
Brooks if you or Imp write the macro I'll do the leg work of converting the current diff to use that macro and remove all my objections from the current state of affairs.

In D17654#377395, @imp wrote:

I'll point out that https://github.com/freebsd is under FreeBSD Project control, for the most part. It's a risk, but this code likely has a limited enough time horizon to accept that limitation until someone can create a fcp.freebsd.org redirector.

Eg, it's not important enough to gate this commit for that.

The projects current and official one source of truth is svn, and forcing anyone to have to use git for anything to do with the project is fundementally wrong at this point in time. I probably would of landed, what is it, a pull request?, to make changes to both the FCP process definition documents, and FCP-101 had it been done in svn.

In D17654#377395, @imp wrote:

I'll point out that https://github.com/freebsd is under FreeBSD Project control, for the most part. It's a risk, but this code likely has a limited enough time horizon to accept that limitation until someone can create a fcp.freebsd.org redirector.

Eg, it's not important enough to gate this commit for that.

The projects current and official one source of truth is svn, and forcing anyone to have to use git for anything to do with the project is fundementally wrong at this point in time. I probably would of landed, what is it, a pull request?, to make changes to both the FCP process definition documents, and FCP-101 had it been done in svn.

I disagree.

First, the FCP process requires git, as defined. Core defined this and approved it. The time to litigate it is over. there's been no demonstrated problems with using this work flow. Quarterly reports are now in git. The project allows these uses of alternative tools to give people the room to innovate without being constrained to dogmatic policies that may have run their course.

Second, the project has *NEVER* said that SVN is the *ONLY* source of truth. We encouraged perforce for a long time. We have had github mirror for a long time. Saying SVN only goes against the grain of what the project has done historically, against the grain of what the larger open source community is doing and is needlessly restrictive.

Which is why I think that this URL is fine. It's an officially blessed use of git by core, and we control the URL where it is to a large degree.

@allanjude suggested we might do something like papers.freebsd.org where we run the git repo though go-hugo to produce a formatted web page. That might be worth doing, but is definitely out of scope for the time being.

  • Add a gone_by_fcp101_dev() macro to make it easier to change the

@allanjude suggested we might do something like papers.freebsd.org where we run the git repo though go-hugo to produce a formatted web page. That might be worth doing, but is definitely out of scope for the time being.

I agree and support this position and effort.

This revision is now accepted and ready to land.Oct 23 2018, 5:44 PM