Page MenuHomeFreeBSD

comms/conserver-com: Update licensing details and pet portlint
ClosedPublic

Authored by 0mp on Oct 12 2018, 8:42 AM.

Details

Summary
  1. For whatever reason I'm getting this fatal error from portlint:

    > FATAL: Makefile: license specified is BSD3CLAUSE OTHERBSDLIKELICENSES, but LICENSE_FILE specified is for BSD3CLAUSE.

    Why do I get it?
  1. This change has to be committed after D17524 because the ${WRKSRC}/LICENSES file was added in 8.2.2.

Makefile changes:

  • Switch the main license from BSD2CLAUSE to BSD3CLAUSE
  • Mention other licenses under whose terms this software is distributed
  • Sort variables
Test Plan
  • portlint
  • poudriere fail at the moment due to the missing ${WRKSRC}/LICENSES file

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

0mp created this revision.Oct 12 2018, 8:42 AM
sbruno accepted this revision.Oct 12 2018, 1:43 PM
This revision is now accepted and ready to land.Oct 12 2018, 1:43 PM
krion accepted this revision.Oct 12 2018, 1:47 PM
sbruno requested changes to this revision.Oct 12 2018, 2:15 PM

FATAL: Makefile: license specified is BSD3CLAUSE OTHERBSDLIKELICENSES, but LICENSE_FILE specified is for BSD3CLAUSE.

portlint seems to dislike the multiple licenses, and to be fair I don't understand why we are defining multiple entries here.

This revision now requires changes to proceed.Oct 12 2018, 2:15 PM
0mp added a comment.Oct 12 2018, 2:28 PM

FATAL: Makefile: license specified is BSD3CLAUSE OTHERBSDLIKELICENSES, but LICENSE_FILE specified is for BSD3CLAUSE.
portlint seems to dislike the multiple licenses, and to be fair I don't understand why we are defining multiple entries here.

I've added OTHERBSDLIKELICENSES because I don't know how to categorize those different licenses: https://github.com/conserver/conserver/blob/master/LICENSES

I don't know what's our approach to the LICENSE variable: is its role to be as precise as possible or to just give a clue of what sort of licenses you should expect if you have a closer look at the licensing.

antoine requested changes to this revision.Oct 12 2018, 3:13 PM
antoine added a subscriber: antoine.

There is no ${WRKSRC}/LICENSES , was this tested?

There is no ${WRKSRC}/LICENSES , was this tested?

Isn't there one if you apply the parent revision first?

0mp added a comment.Oct 12 2018, 3:18 PM

There is no ${WRKSRC}/LICENSES , was this tested?

First of all, thanks for testing out my patch :)

You are right, the file is not there (yet) and I'm aware of it. See the description of the revision.

This revision was not accepted when it landed; it landed in state Needs Revision.Oct 12 2018, 4:08 PM
This revision was automatically updated to reflect the committed changes.