Page MenuHomeFreeBSD

pfsync: Ensure uninit is done before pf
ClosedPublic

Authored by kp on Oct 10 2018, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:55 PM
Unknown Object (File)
Thu, Dec 12, 2:57 PM
Unknown Object (File)
Mon, Dec 9, 12:34 PM
Unknown Object (File)
Nov 8 2024, 10:24 PM
Unknown Object (File)
Nov 8 2024, 3:59 AM
Unknown Object (File)
Nov 2 2024, 9:50 AM
Unknown Object (File)
Sep 18 2024, 2:16 AM
Unknown Object (File)
Sep 17 2024, 3:40 AM
Subscribers

Details

Summary

pfsync touches pf memory (for pf_state and the pfsync callback
pointers), not the other way around. We need to ensure that pfsync is
torn down before pf.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20116
Build 19610: arc lint + arc unit

Event Timeline

I assume the "other way round" is only true after the function pointers have been virtualised, otherwise not.
And that makes me wonder..

OK, this only makes sense after the callback functions are virtualized; before the above comment did make sense but was expecting a different architechtural solution (whether true or not at the time of writing)

This revision is now accepted and ready to land.Oct 10 2018, 6:50 PM
This revision was automatically updated to reflect the committed changes.