Page MenuHomeFreeBSD

Remove the need for backslashes in syscalls.master.
ClosedPublic

Authored by brooks on Oct 9 2018, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 18 2024, 8:05 PM
Unknown Object (File)
Oct 4 2024, 2:27 AM
Unknown Object (File)
Sep 18 2024, 6:39 PM
Unknown Object (File)
Sep 8 2024, 12:29 AM
Unknown Object (File)
Sep 4 2024, 5:08 PM
Unknown Object (File)
Sep 3 2024, 3:32 PM
Unknown Object (File)
Sep 3 2024, 8:50 AM
Unknown Object (File)
Aug 6 2024, 8:15 AM
Subscribers
None

Details

Summary

Join non-special lines together until we hit a line containing a '}'
character. This allows the function declaration body to be split
across multiple lines without backslash continuation characters.

Continue to join lines ending with backslashes to allow gradual
migration and to support out-of-tree syscall vectors.

Test Plan

verified no changes in generated files

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added inline comments.
sys/kern/makesyscalls.sh
81 ↗(On Diff #48953)

we join with a space now?

This revision is now accepted and ready to land.Oct 10 2018, 12:43 AM

Might be it is a good idea to check that there is no nesting '(' or unbalanced ')' ?

brooks marked an inline comment as done.
  • Join without spaceso (previous behavior).
This revision now requires review to proceed.Oct 10 2018, 3:25 PM
  • Join without spaceso (previous behavior).

I didn't have a strong opinion on this either way, just wanted to make sure it was an intentional change.

This revision is now accepted and ready to land.Oct 10 2018, 3:26 PM
In D17488#373351, @kib wrote:

Might be it is a good idea to check that there is no nesting '(' or unbalanced ')' ?

The awk line parser makes sure things are of the form:

{<return_type> <function>(<arg_list>);}

I suppose one could check that <arg_list> contains balanced parentheses, but that seems beyond the scope of this change.

  • Join without spaceso (previous behavior).

I didn't have a strong opinion on this either way, just wanted to make sure it was an intentional change.

I didn't have a strong opinion and when I tried writing down my motivation for the change it sounded weak...

  • Allow both types of joins to be mixed. This makes it easier to semi-programatically convert files where alternative names are wrapped with backslashes.
This revision now requires review to proceed.Oct 15 2018, 8:07 PM
This revision is now accepted and ready to land.Oct 15 2018, 9:25 PM
This revision was automatically updated to reflect the committed changes.