cmake's /out of sourcetree/ builds should be the default behaviour.
So make it so.
- cmake:outsource is no longer valid,
- cmake:insource makes it build in the source tree.
Differential D17447 Authored by tcberner on Oct 6 2018, 7:35 AM.
Details
Summary cmake's /out of sourcetree/ builds should be the default behaviour.
Test Plan
Diff Detail
Event TimelineHerald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptOct 6 2018, 7:36 AM2018-10-06 07:36:20 (UTC+0) Harbormaster completed remote builds in B20024: Diff 48821.Oct 6 2018, 7:36 AM2018-10-06 07:36:37 (UTC+0) Comment Actions There does not seem to be any use of :insource, do you plan on having the exp-run tell you which port will need it? (Other than that, looks good.) Comment Actions
I'm building all the cmake ports and will be adding it where needed, yes. After that, I'll ask for an exp-run. Harbormaster completed remote builds in B20039: Diff 48840.Oct 6 2018, 10:14 PM2018-10-06 22:14:53 (UTC+0) Comment Actions
Sure, I can hold off on it until decembre. Large DiffThis large diff affects 1,164 files. Files without inline comments have been collapsed. Expand All Files
Revision Contents
Diff 48840 |