Page MenuHomeFreeBSD

cmake.mk: make `outsource` the default behaviour
AbandonedPublic

Authored by tcberner on Oct 6 2018, 7:35 AM.

Details

Summary

cmake's /out of sourcetree/ builds should be the default behaviour.
So make it so.

  • cmake:outsource is no longer valid,
  • cmake:insource makes it build in the source tree.
Test Plan
  • Run a build on on all cmake ports (in progress) and add :insource to the handful that actually need it.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20039
Build 19543: arc lint + arc unit

Event Timeline

tcberner created this revision.Oct 6 2018, 7:35 AM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptOct 6 2018, 7:36 AM
arrowd added a subscriber: arrowd.Oct 6 2018, 8:16 AM

Haven't looked into every change, OFC, but .mk and CHANGES LGTM.

mat added a comment.EditedOct 6 2018, 8:40 AM

There does not seem to be any use of :insource, do you plan on having the exp-run tell you which port will need it?

(Other than that, looks good.)

tcberner added a comment.EditedOct 6 2018, 9:04 AM
In D17447#372154, @mat wrote:

There does not seem to be any use of :insource, do you plan on having the exp-run tell you which port will need it?
(Other than that, looks good.)

I'm building all the cmake ports and will be adding it where needed, yes. After that, I'll ask for an exp-run.

tcberner updated this revision to Diff 48840.Oct 6 2018, 10:14 PM

Add :insource to the ports that need it.

Could this kind of change be done just before quarterly ? this makes MFH painful.

Could this kind of change be done just before quarterly ? this makes MFH painful.

Sure, I can hold off on it until decembre.

tcberner abandoned this revision.Dec 29 2018, 11:11 PM