Page MenuHomeFreeBSD

cmake.mk: make `outsource` the default behaviour
AbandonedPublic

Authored by tcberner on Oct 6 2018, 7:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 28, 2:33 AM
Unknown Object (File)
Feb 12 2024, 4:43 PM
Unknown Object (File)
Jan 12 2024, 5:46 PM
Unknown Object (File)
Oct 3 2023, 12:57 PM
Unknown Object (File)
Sep 19 2023, 6:31 AM
Unknown Object (File)
Aug 6 2023, 11:17 AM
Unknown Object (File)
Jun 29 2023, 6:40 PM
Unknown Object (File)
Jun 17 2023, 10:14 PM
Subscribers

Details

Summary

cmake's /out of sourcetree/ builds should be the default behaviour.
So make it so.

  • cmake:outsource is no longer valid,
  • cmake:insource makes it build in the source tree.
Test Plan
  • Run a build on on all cmake ports (in progress) and add :insource to the handful that actually need it.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20039
Build 19543: arc lint + arc unit

Event Timeline

Haven't looked into every change, OFC, but .mk and CHANGES LGTM.

There does not seem to be any use of :insource, do you plan on having the exp-run tell you which port will need it?

(Other than that, looks good.)

In D17447#372154, @mat wrote:

There does not seem to be any use of :insource, do you plan on having the exp-run tell you which port will need it?

(Other than that, looks good.)

I'm building all the cmake ports and will be adding it where needed, yes. After that, I'll ask for an exp-run.

Add :insource to the ports that need it.

Could this kind of change be done just before quarterly ? this makes MFH painful.

Could this kind of change be done just before quarterly ? this makes MFH painful.

Sure, I can hold off on it until decembre.