Speed up devel/gdb startup on FreeBSD
ClosedPublic
Actions

Authored by jhb on Oct 5 2018, 12:06 AM.

Details

Reviewers

mmacy
jmd
luca.pizzamiglio_gmail.com
pizzamig
bdragon

Commits

rP486773: Speed up devel/gdb startup on FreeBSD

Summary

On non-Linux systems that do not have fdwalk(), gdb currently iterates over all possible file descriptors when checking for open files.
Fix this by adding a FreeBSD implementation using kinfo_getfile().

Fixes extremely long startup times on ppc64.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Oct 5 2018, 12:06 AM

Herald added subscribers: mat, emaste. · View Herald TranscriptOct 5 2018, 12:06 AM

Harbormaster completed remote builds in B19991: Diff 48762.Oct 5 2018, 12:06 AM

mmacy added reviewers: jhb, jmd.Oct 5 2018, 12:25 AM

kbowling added a subscriber: kbowling.Oct 9 2018, 7:24 AM

linimon retitled this revision from Speed up gdb startup on FreeBSD to Speed up devel/gdb startup on FreeBSD.Oct 9 2018, 3:22 PM

I've merged a similar change upstream to gdb in commit 93579f6f90. We can pull that into the port as a commit-<foo> patch.

Use patch from upstream commit.
Bump PORTREVISION.

jhb added a reviewer: luca.pizzamiglio_gmail.com.Nov 30 2018, 11:25 PM

Harbormaster completed remote builds in B21285: Diff 51452.Nov 30 2018, 11:25 PM

Patch doesn't apply cleanly.

devel/gdb/files/commit-93579f6f90
16 ↗	(On Diff #51452)	This section of the patch fails, because the ChangeLog in the release is missing the latest changes. I'd remove the Changelog diff from the patch