Page MenuHomeFreeBSD

New port: math/cddlib - C implementation of the Double Description Method of Motzkin et al
ClosedPublic

Authored by fernape on Oct 2 2018, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 25 2024, 10:59 PM
Unknown Object (File)
Oct 25 2024, 10:59 PM
Unknown Object (File)
Oct 25 2024, 10:59 PM
Unknown Object (File)
Oct 25 2024, 10:59 PM
Unknown Object (File)
Oct 25 2024, 9:48 PM
Unknown Object (File)
Oct 25 2024, 9:47 PM
Unknown Object (File)
Oct 25 2024, 9:47 PM
Unknown Object (File)
Oct 25 2024, 9:47 PM
Subscribers

Details

Summary

New port for the math category.

Submitted PR 231161

I reordered some variables from the original patch.
I also checked no other ports install this library.

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 11.2amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20123
Build 19617: arc lint + arc unit

Event Timeline

tcberner requested changes to this revision.Oct 2 2018, 9:42 PM

Give me an m give me an a give me a math/Makefile change

This revision now requires changes to proceed.Oct 2 2018, 9:42 PM
math/cddlib/Makefile
28

^that looks like USES=loclabase:ldflags should get you there.

math/cddlib/pkg-descr
15

No www

math/cddlib/Makefile
23–26

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

  • Move _BUILD_* variable to "The Targets" section
  • Add missing math/Makefile change

Give me an m give me an a give me a math/Makefile change

Attaching the new port to the tree is clearly overrated :P

math/cddlib/pkg-descr
14

^ not sure if pkg-descr is really the right place to put that warning :)

Move Warning message to pre-build-DOCS-on stage

fernape added inline comments.
math/cddlib/pkg-descr
14

No, it's not!

By the way, the message shows up but I personally think it would be nice if paused the building for a couple of seconds or so, so the user can decide if he/she wants to abort. Is there a way of doing this? I couldn't find it in the Handbook (maybe for a good reason)

math/cddlib/pkg-descr
14

I think it's even fine without a message. If you think the build time is too long for the normal "DOCS" option, then the proper way would probably be to add a GENDOCS option with a DESC that says in a better way "build doc (with heavy deps)". And then make the implications as in the other cases you handled recently.

math/cddlib/Makefile
25

This should probably go after the options block, not in the middle of it. See Chapter 15. Order of Variables in Port Makefiles.

30–32

Nobody will ever read this message. The DOCS option should have no, or light dependencies. If there are heavy dependencies (like doxygen) the option should be name otherwise, in this case, maybe MANUAL, or something.

  • Remove warning message completely
  • Move HEADERSDIR variable down.
fernape added inline comments.
math/cddlib/pkg-descr
14

Building time with DOCSon does not seem excessive at least to me. So we are probably fine without the warning message.

math/cddlib/pkg-descr
14

It's not about build times, it's about dependency chain. lexlive is a bit too big for it.

fernape marked an inline comment as done.

Change from DOCS to MANUAL and warn about the dependency chain in the configuration menu

This revision was not accepted when it landed; it landed in state Needs Review.Oct 13 2018, 4:29 PM
Closed by commit rP481995: New port: math/cddlib (authored by fernape). · Explain Why
This revision was automatically updated to reflect the committed changes.