Page MenuHomeFreeBSD
Differential D17385

New port: math/cddlib - C implementation of the Double Description Method of Motzkin et al
ClosedPublic
Actions

Authored by fernape on Oct 2 2018, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 10:59 PM
Unknown Object (File)
Fri, Oct 25, 10:59 PM
Unknown Object (File)
Fri, Oct 25, 10:59 PM
Unknown Object (File)
Fri, Oct 25, 10:59 PM
Unknown Object (File)
Fri, Oct 25, 9:48 PM
Unknown Object (File)
Fri, Oct 25, 9:47 PM
Unknown Object (File)
Fri, Oct 25, 9:47 PM
Unknown Object (File)
Fri, Oct 25, 9:47 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
tz
Commits
rP481995: New port: math/cddlib
Summary

New port for the math category.

Submitted PR 231161

I reordered some variables from the original patch.
I also checked no other ports install this library.

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 11.2amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape created this revision.Oct 2 2018, 8:49 PM
Herald added a subscriber: mat. · View Herald TranscriptOct 2 2018, 8:49 PM
Harbormaster completed remote builds in B19917: Diff 48660.Oct 2 2018, 8:49 PM
fernape edited the summary of this revision. (Show Details)Oct 2 2018, 8:52 PM
tcberner requested changes to this revision.Oct 2 2018, 9:42 PM

Give me an m give me an a give me a math/Makefile change

This revision now requires changes to proceed.Oct 2 2018, 9:42 PM
tcberner added inline comments.Oct 2 2018, 9:47 PM
math/cddlib/Makefile
27 ↗(On Diff #48660)

^that looks like USES=loclabase:ldflags should get you there.

math/cddlib/pkg-descr
14 ↗(On Diff #48660)

No www

mat added inline comments.Oct 3 2018, 8:46 AM
math/cddlib/Makefile
22–25 ↗(On Diff #48660)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

fernape updated this revision to Diff 48674.Oct 3 2018, 3:41 PM
  • Move _BUILD_* variable to "The Targets" section
  • Add missing math/Makefile change
Harbormaster completed remote builds in B19925: Diff 48674.Oct 3 2018, 3:41 PM
fernape marked 2 inline comments as done.Oct 3 2018, 3:44 PM
In D17385#370876, @tcberner wrote:

Give me an m give me an a give me a math/Makefile change

Attaching the new port to the tree is clearly overrated :P

fernape updated this revision to Diff 48675.Oct 3 2018, 3:45 PM

Add `WWW``` to pkg-desc

Harbormaster completed remote builds in B19926: Diff 48675.Oct 3 2018, 3:45 PM
tcberner added a comment.Oct 3 2018, 8:48 PM
math/cddlib/pkg-descr
13 ↗(On Diff #48675)

^ not sure if pkg-descr is really the right place to put that warning :)

fernape updated this revision to Diff 48695.Oct 3 2018, 9:26 PM

Move Warning message to pre-build-DOCS-on stage

Harbormaster completed remote builds in B19941: Diff 48695.Oct 3 2018, 9:26 PM
fernape marked 3 inline comments as done.Oct 3 2018, 9:28 PM
fernape added inline comments.
math/cddlib/pkg-descr
13 ↗(On Diff #48675)

No, it's not!

By the way, the message shows up but I personally think it would be nice if paused the building for a couple of seconds or so, so the user can decide if he/she wants to abort. Is there a way of doing this? I couldn't find it in the Handbook (maybe for a good reason)

fernape marked an inline comment as done.Oct 4 2018, 8:52 PM
tcberner added inline comments.Oct 6 2018, 7:45 AM
math/cddlib/pkg-descr
13 ↗(On Diff #48675)

I think it's even fine without a message. If you think the build time is too long for the normal "DOCS" option, then the proper way would probably be to add a GENDOCS option with a DESC that says in a better way "build doc (with heavy deps)". And then make the implications as in the other cases you handled recently.

mat added inline comments.Oct 6 2018, 8:35 AM
math/cddlib/Makefile
24 ↗(On Diff #48695)

This should probably go after the options block, not in the middle of it. See Chapter 15. Order of Variables in Port Makefiles.

29–31 ↗(On Diff #48695)

Nobody will ever read this message. The DOCS option should have no, or light dependencies. If there are heavy dependencies (like doxygen) the option should be name otherwise, in this case, maybe MANUAL, or something.

fernape updated this revision to Diff 48832.Oct 6 2018, 2:52 PM
  • Remove warning message completely
  • Move HEADERSDIR variable down.
Harbormaster completed remote builds in B20033: Diff 48832.Oct 6 2018, 2:52 PM
fernape marked 4 inline comments as done.Oct 6 2018, 2:55 PM
fernape added inline comments.
math/cddlib/pkg-descr
13 ↗(On Diff #48675)

Building time with DOCSon does not seem excessive at least to me. So we are probably fine without the warning message.

mat added inline comments.Oct 6 2018, 6:54 PM
math/cddlib/pkg-descr
13 ↗(On Diff #48675)

It's not about build times, it's about dependency chain. lexlive is a bit too big for it.

fernape updated this revision to Diff 48981.Oct 10 2018, 4:20 PM
fernape marked an inline comment as done.

Change from DOCS to MANUAL and warn about the dependency chain in the configuration menu

Harbormaster completed remote builds in B20123: Diff 48981.Oct 10 2018, 4:20 PM
fernape marked an inline comment as done.Oct 13 2018, 4:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 13 2018, 4:29 PM
Closed by commit rP481995: New port: math/cddlib (authored by fernape). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
math/
1 line
cddlib/
50 lines
3 lines
13 lines
134 lines

Diff 49097

View Options

head/math/Makefile

Loading...
View Options

head/math/cddlib/Makefile

Loading...
View Options

head/math/cddlib/distinfo

Loading...
View Options

head/math/cddlib/pkg-descr

Loading...
View Options

head/math/cddlib/pkg-plist

Loading...