Page MenuHomeFreeBSD
Differential D17383

Mention "race conditions" in the section about MAKE_JOBS_UNSAFE.
ClosedPublic
Actions

Authored by 0mp on Oct 2 2018, 4:51 PM.
Tags
None
Referenced Files
F162547544: D17383.id.diff
Tue, Jul 14, 10:28 AM
Unknown Object (File)
Mon, Jul 13, 4:15 PM
Unknown Object (File)
Sat, Jul 4, 1:31 PM
Unknown Object (File)
Sat, Jul 4, 8:42 AM
Unknown Object (File)
Fri, Jul 3, 1:09 PM
Unknown Object (File)
Fri, Jul 3, 3:29 AM
Unknown Object (File)
Thu, Jul 2, 6:56 PM
Unknown Object (File)
Thu, Jul 2, 1:42 AM
View All Files
Subscribers
None

Details

Reviewers
bcr
eadler
mat
krion
Commits
rD52413: Mention "race conditions" in the section about MAKE_JOBS_UNSAFE.
Summary

The reason for this is to increase discoverability of MAKE_JOBS_UNSAFE.

Test Plan

HTML version renders just fine in the browser.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Oct 2 2018, 4:51 PM
Herald added 1 blocking reviewer(s): mat. · View Herald TranscriptOct 2 2018, 4:51 PM
Harbormaster completed remote builds in B19910: Diff 48652.Oct 2 2018, 4:51 PM
bcr accepted this revision.Oct 2 2018, 5:02 PM

Fine for me.

mat accepted this revision.Oct 3 2018, 8:44 AM

Though, it might be nice to expand a bit, saying that the failures can be intermittent, or something.

This revision is now accepted and ready to land.Oct 3 2018, 8:44 AM
0mp added a comment.Oct 8 2018, 8:20 AM
In D17383#370947, @mat wrote:

Though, it might be nice to expand a bit, saying that the failures can be intermittent, or something.

@mat, how about something like:

It is used when a port is known to be broken with <varname>-jX</varname> due to race conditions causing intermittent build failures.

0mp updated this revision to Diff 49655.Oct 26 2018, 3:04 PM
  • Improve the description (as requested by @mat).
  • Use <literal> instead of <varname> for options similarly to how --with-xxx is formated later on in the handbook.
This revision now requires review to proceed.Oct 26 2018, 3:04 PM
Harbormaster completed remote builds in B20450: Diff 49655.Oct 26 2018, 3:04 PM
bcr accepted this revision.Oct 29 2018, 1:29 PM

Approved for commit. Thanks for reminding.

This revision is now accepted and ready to land.Oct 29 2018, 1:29 PM
Closed by commit rD52413: Mention "race conditions" in the section about MAKE_JOBS_UNSAFE. (authored by 0mp). · Explain WhyOct 29 2018, 1:41 PM
This revision was automatically updated to reflect the committed changes.
0mp added a comment.Oct 29 2018, 1:41 PM

Thank you!

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
books/
porters-handbook/
special/
5 lines

Diff 49752

View Options

head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml

Loading...