Page MenuHomeFreeBSD
Differential D17341

Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64.
ClosedPublic
Actions

Authored by andrew on Sep 27 2018, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:27 AM
Unknown Object (File)
Sep 14 2023, 9:21 AM
Unknown Object (File)
Sep 8 2023, 12:41 PM
Unknown Object (File)
Sep 2 2023, 9:13 AM
Unknown Object (File)
Aug 18 2023, 5:28 PM
Unknown Object (File)
Aug 13 2023, 6:17 AM
Unknown Object (File)
Aug 12 2023, 4:36 PM
Unknown Object (File)
Aug 2 2023, 6:09 PM
View All 20 Files
Subscribers
emaste
imp

Details

Reviewers
kib
Group Reviewers
arm64
Commits
rS339041: Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64.
Summary

This is based on the amd64 implementation. Support for both PLT and
non-PLT (e.g. a global variable initilised with a pointer to an ifunc)
cases are supported.

We don't pass anything to the resolver as it is expected they will read
the ID registers directly, with the number of registers with CPU info
likely to increase in the future.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19862
Build 19390: arc lint + arc unit

Event Timeline

andrew created this revision.Sep 27 2018, 5:28 PM
Herald added a subscriber: emaste. · View Herald TranscriptSep 27 2018, 5:28 PM
Harbormaster completed remote builds in B19845: Diff 48526.Sep 27 2018, 5:28 PM
kib added a comment.Sep 27 2018, 8:26 PM

I expect that glibc passes AT_HWCAP/HWCAP2 as the resolver arguments.

libexec/rtld-elf/aarch64/reloc.c
294

Follow style, move declarations to the start of the function.

321

Same there.

andrew marked an inline comment as done.Sep 28 2018, 8:17 AM

I'm considering passing 8 zeros to the handler so it will have a defined value that could be changed later, but where handlers can ignore them by not taking any arguments.

libexec/rtld-elf/aarch64/reloc.c
294

This was copied from the amd64 implementation so should probably also be fixed there.

andrew updated this revision to Diff 48545.Sep 28 2018, 8:44 AM

Style

Harbormaster completed remote builds in B19857: Diff 48545.Sep 28 2018, 8:44 AM
andrew marked 2 inline comments as done.Sep 28 2018, 8:44 AM
kib added inline comments.Sep 28 2018, 10:15 AM
libexec/rtld-elf/aarch64/reloc.c
301

Why do you stop the loop on the first relocation processed ?

334

And there ?

andrew updated this revision to Diff 48547.Sep 28 2018, 11:22 AM
andrew marked 3 inline comments as done.

Remove break statements that shouldn't be there.

Harbormaster completed remote builds in B19859: Diff 48547.Sep 28 2018, 11:22 AM
andrew added inline comments.Sep 28 2018, 11:22 AM
libexec/rtld-elf/aarch64/reloc.c
301

I missed them when changing a switch with a single case to an if.

kib accepted this revision.Sep 28 2018, 12:08 PM
This revision is now accepted and ready to land.Sep 28 2018, 12:08 PM
andrew updated this revision to Diff 48551.Sep 28 2018, 2:22 PM

Pass in zeros to call_ifunc_resolver so we can change them later

This revision now requires review to proceed.Sep 28 2018, 2:22 PM
Harbormaster completed remote builds in B19862: Diff 48551.Sep 28 2018, 2:22 PM
kib accepted this revision.Sep 28 2018, 4:23 PM
kib added inline comments.
libexec/rtld-elf/aarch64/rtld_machdep.h
67

to seE

This revision is now accepted and ready to land.Sep 28 2018, 4:23 PM
Closed by commit rS339041: Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64. (authored by andrew). · Explain WhyOct 1 2018, 2:02 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptOct 1 2018, 2:02 PM

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
aarch64/
132 lines
10 lines

Diff 48551

View Options

libexec/rtld-elf/aarch64/reloc.c

Loading...
View Options

libexec/rtld-elf/aarch64/rtld_machdep.h

Loading...