Page MenuHomeFreeBSD
Differential D17335

Relax INP_INFO_UNLOCK_ASSERT() assertion in tcp_input()
ClosedPublic
Actions

Authored by ae on Sep 27 2018, 11:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 27, 6:00 PM
Unknown Object (File)
Thu, Mar 19, 6:16 AM
Unknown Object (File)
Thu, Mar 19, 1:28 AM
Unknown Object (File)
Thu, Mar 19, 1:28 AM
Unknown Object (File)
Sat, Mar 14, 9:55 PM
Unknown Object (File)
Feb 26 2026, 2:08 PM
Unknown Object (File)
Feb 26 2026, 5:58 AM
Unknown Object (File)
Dec 2 2025, 9:29 AM
View All Files
Subscribers
imp

Details

Reviewers
rrs
mmacy
tuexen
Group Reviewers
transport
Commits
rS339039: Add INP_INFO_WUNLOCK_ASSERT() macro and use it instead of
Summary

After rS334671 encapsulated traffic always handled in net_epoch_preempt section.
In case, when TCP session uses IP addresses configured on tunneling interfaces and INVARIANTS is enabled, INP_INFO_UNLOCK_ASSERT() fires.
This patch relaxes requirements for this assertion by removing !in_epoch(net_epoch_preempt). New macro INP_INFO_WUNLOCK_ASSERT() added, it only requires that tcbinfo mutex is not owned.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231428

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ae created this revision.Sep 27 2018, 11:12 AM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptSep 27 2018, 11:12 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B19837: Diff 48502.Sep 27 2018, 11:12 AM
ae added a comment.Sep 30 2018, 12:11 PM

any objections?

tuexen accepted this revision.Sep 30 2018, 12:21 PM

Assuming this change is tested somehow...

This revision is now accepted and ready to land.Sep 30 2018, 12:21 PM
mmacy accepted this revision.Sep 30 2018, 10:13 PM

Seems fine for now.

Closed by commit rS339039: Add INP_INFO_WUNLOCK_ASSERT() macro and use it instead of (authored by ae). · Explain WhyOct 1 2018, 10:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
2 lines
2 lines
4 lines
10 lines

Diff 48606

View Options

head/sys/netinet/in_pcb.h

Loading...
View Options

head/sys/netinet/siftr.c

Loading...
View Options

head/sys/netinet/tcp_hpts.c

Loading...
View Options

head/sys/netinet/tcp_input.c

Loading...