Paths

Table of Contentst

Differential D17335

Relax INP_INFO_UNLOCK_ASSERT() assertion in tcp_input()
ClosedPublic
Actions

Authored by ae on Sep 27 2018, 11:12 AM.

Tags

None

Referenced Files

	F173387294: D17335.diff
	Fri, Sep 25, 3:22 PM

	Unknown Object (File)
	Fri, Sep 18, 11:15 AM

	Unknown Object (File)
	Fri, Sep 11, 1:40 PM

	Unknown Object (File)
	Fri, Sep 11, 12:38 PM

	Unknown Object (File)
	Thu, Sep 10, 6:20 PM

	Unknown Object (File)
	Thu, Sep 10, 2:18 PM

	Unknown Object (File)
	Wed, Sep 9, 3:21 PM

	Unknown Object (File)
	Wed, Sep 9, 11:19 AM

Subscribers

Details

Reviewers

rrs
mmacy
tuexen

Group Reviewers

Commits

rS339039: Add INP_INFO_WUNLOCK_ASSERT() macro and use it instead of

Summary

After rS334671 encapsulated traffic always handled in net_epoch_preempt section.
In case, when TCP session uses IP addresses configured on tunneling interfaces and INVARIANTS is enabled, INP_INFO_UNLOCK_ASSERT() fires.
This patch relaxes requirements for this assertion by removing !in_epoch(net_epoch_preempt). New macro INP_INFO_WUNLOCK_ASSERT() added, it only requires that tcbinfo mutex is not owned.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231428

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ae created this revision.Sep 27 2018, 11:12 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptSep 27 2018, 11:12 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B19837: Diff 48502.Sep 27 2018, 11:12 AM

any objections?

Assuming this change is tested somehow...

This revision is now accepted and ready to land.Sep 30 2018, 12:21 PM

Seems fine for now.

Closed by commit rS339039: Add INP_INFO_WUNLOCK_ASSERT() macro and use it instead of (authored by ae). · Explain WhyOct 1 2018, 10:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

2 lines

2 lines

4 lines

10 lines

Diff 48606

head/sys/netinet/in_pcb.h

Loading...

head/sys/netinet/siftr.c

Loading...

head/sys/netinet/tcp_hpts.c

Loading...

head/sys/netinet/tcp_input.c

Loading...