Centralize compat support for PCIOCGETCONF.
ClosedPublic
Actions

Authored by brooks on Sep 25 2018, 10:32 PM.

Details

Reviewers

kib
jhb

Commits

rS338990: Centralize compat support for PCIOCGETCONF.

Summary

The pre-7 compat for both native and 32-bit code was already in
pci_user.c. Use this infrastructure to add implement 32-bit support.

Obtained from: CheriBSD

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19817
Build 19354: arc lint + arc unit

Event Timeline

brooks created this revision.Sep 25 2018, 10:32 PM

Harbormaster completed remote builds in B19817: Diff 48466.Sep 25 2018, 10:32 PM

Why did you moved everything but pci bar mmap case ?

In D17324#369437, @kib wrote:

Why did you moved everything but pci bar mmap case ?

Because I already had this code (pre-dating the pci bar mmap case's existence). I'm happy to move it, but would prefer to do it in a separate change.

In D17324#369486, @brooks wrote:

In D17324#369437, @kib wrote:

Why did you moved everything but pci bar mmap case ?

Because I already had this code (pre-dating the pci bar mmap case's existence). I'm happy to move it, but would prefer to do it in a separate change.

Ok. The move has more important consequence than just the code structure. Ioctl commands are specific to file descriptor, so the approach of freebsd32_ioctl() is flawed beyond repair. This is one of the reason of me asking about bar mmap.

This revision is now accepted and ready to land.Sep 26 2018, 10:22 PM

Agree with kib on the general point that all of freebsd32_ioctl is probably busted and should be moved to the actual ioctl handlers.

Closed by commit rS338990: Centralize compat support for PCIOCGETCONF. (authored by brooks). · Explain WhySep 27 2018, 9:08 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptSep 27 2018, 9:08 PM