Page MenuHomeFreeBSD

Centralize compat support for PCIOCGETCONF.
ClosedPublic

Authored by brooks on Sep 25 2018, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 27, 4:49 PM
Unknown Object (File)
Sat, Mar 21, 5:02 AM
Unknown Object (File)
Fri, Mar 20, 12:34 AM
Unknown Object (File)
Thu, Mar 19, 8:36 AM
Unknown Object (File)
Thu, Mar 19, 7:20 AM
Unknown Object (File)
Wed, Mar 18, 9:44 PM
Unknown Object (File)
Wed, Mar 18, 10:40 AM
Unknown Object (File)
Tue, Mar 17, 5:39 AM
Subscribers

Details

Summary

The pre-7 compat for both native and 32-bit code was already in
pci_user.c. Use this infrastructure to add implement 32-bit support.

Obtained from: CheriBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Why did you moved everything but pci bar mmap case ?

In D17324#369437, @kib wrote:

Why did you moved everything but pci bar mmap case ?

Because I already had this code (pre-dating the pci bar mmap case's existence). I'm happy to move it, but would prefer to do it in a separate change.

In D17324#369437, @kib wrote:

Why did you moved everything but pci bar mmap case ?

Because I already had this code (pre-dating the pci bar mmap case's existence). I'm happy to move it, but would prefer to do it in a separate change.

Ok. The move has more important consequence than just the code structure. Ioctl commands are specific to file descriptor, so the approach of freebsd32_ioctl() is flawed beyond repair. This is one of the reason of me asking about bar mmap.

This revision is now accepted and ready to land.Sep 26 2018, 10:22 PM

Agree with kib on the general point that all of freebsd32_ioctl is probably busted and should be moved to the actual ioctl handlers.

This revision was automatically updated to reflect the committed changes.