Move kernel vmem arena initialization to vm_kern.c.
ClosedPublic
Actions

Authored by markj on Sep 19 2018, 5:20 PM.

Details

Reviewers

Commits

Summary

The details of this initialization belong in vm_kern.c anyway, and allow
me to use KVA_QUANTUM in vm_kern.c without defining it in a header.

No functional change intended.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

alc accepted this revision.Sep 19 2018, 5:54 PM

alc added inline comments.

sys/vm/vm_kern.c
745–747 ↗	(On Diff #48229)	It's not clear to me that using vmem_alloc() as the import function guarantees alignment. I fear that we are only guaranteed that the size is a multiple of KVA_QUANTUM.

This revision is now accepted and ready to land.Sep 19 2018, 5:54 PM

markj marked 2 inline comments as done.Sep 19 2018, 6:28 PM

markj added inline comments.

sys/vm/vm_kern.c
745–747 ↗	(On Diff #48229)	I think you're right, and the problem is only hidden as a result of the current kernel arena usage patterns. In particular, vmem freelist entries aren't necessarily size-aligned.