Page MenuHomeFreeBSD

lld: add -z nodump support
AbandonedPublic

Authored by emaste on Sep 14 2018, 1:53 PM.

Details

Reviewers
dim
markj
Summary

-z nodump sets the DF_1_NODUMP flag, marking the object as not dumpable by the runtime linker.

FreeBSD does not support DF_1_NODUMP, so the flag will be set in the object but ignored by rtld.

PR:             230603
Reported by:    jbeich
Sponsored by:   The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste created this revision.Sep 14 2018, 1:53 PM
markj accepted this revision.Sep 14 2018, 2:58 PM
This revision is now accepted and ready to land.Sep 14 2018, 2:58 PM
dim accepted this revision.Sep 14 2018, 4:10 PM

LGTM. I assume this is going upstream too?

Yeah I posted an upstream review in https://reviews.llvm.org/D52096 but based on what Mark found on the mailing list I'm more inclined to say we don't want to support this misfeature and push back on the port(s) that try to use it.

emaste abandoned this revision.Sep 14 2018, 5:32 PM

Based on what Mark found it looks like dldump() applies only to Solaris and was done specifically for emacs, so it's not worth the effort of carrying this feature in lld.