Page MenuHomeFreeBSD

[new port] math/sleef: SIMD Library for Evaluating Elementary Functions, vectorized libm and DFT
ClosedPublic

Authored by jmd on Sep 5 2018, 2:40 PM.

Details

Summary

This adds sleef.

Test Plan

poudriere tested on HEAD amd64, 11.1 amd64, 11.1 i386.

portlint -Aac clean except for the version-based check.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmd created this revision.Sep 5 2018, 2:40 PM
jmd updated this revision to Diff 47705.Sep 5 2018, 7:05 PM

use IGNORE_FreeBSD_10 and extend pkg-descr

seanc added a subscriber: seanc.Sep 5 2018, 8:10 PM
mat added inline comments.Sep 6 2018, 12:43 PM
math/sleef/Makefile
5 ↗(On Diff #47705)
21 ↗(On Diff #47705)

Remove this.

jmd updated this revision to Diff 47748.Sep 6 2018, 1:43 PM

Address comments that portlint didn't complain about.

jmd marked an inline comment as done.Sep 6 2018, 1:43 PM

Unfortunately, portlint didn't complain about this.

mat added a comment.Sep 6 2018, 3:05 PM
In D17045#363633, @jmd wrote:

Unfortunately, portlint didn't complain about this.

I am not sure what you mean. portlint is a static lint tool, it can tell you when stuff are out of order, or something should not be there, but I cannot see how it could understand what you are doing and know you are wrong. This is why we have committers, a group of people who actually know our rules, policies, and usages, and can adapt submissions to fit them.

jmd added a comment.Sep 6 2018, 3:15 PM

These things keep improving/changing and it would be very helpful for me, as a member of that group of committers trying to keep up with rules and do the right thing, if there were tools assisting me.

Could you be so kind as to mark the review as approved (and the others you selected to do) if you are now happy? Thank you!

zeising accepted this revision.Sep 6 2018, 7:22 PM

Looks good, approved.

This revision is now accepted and ready to land.Sep 6 2018, 7:22 PM
This revision was automatically updated to reflect the committed changes.