Page MenuHomeFreeBSD

net/ss5: Fix missing @sample(s) in plist
AbandonedPublic

Authored by tobik on Sep 5 2018, 4:53 AM.

Details

Summary

Fixed plist issue

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19407
Build 19006: arc lint + arc unit

Event Timeline

The difference in patches is because i converted the patches to proper way: make patch then make makepatches

tobik added inline comments.Sep 5 2018, 5:07 AM
net/ss5/Makefile
4–7

Use

DISTVERSION=	3.8.9-8

here.

8
MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/${DISTVERSION}
16
WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION:R}
net/ss5/pkg-plist
0–3

This does not make sense.

@sample %%ETCDIR%%/ss5.passwd.sample

will create

/usr/local/etc/ss5/ss5.passwd

during the package install iff ss5.passwd didn't exist previously. So the entries without @sample need to be removed.

ndowens_yahoo.com marked 4 inline comments as done.Sep 5 2018, 5:13 AM

Updating D17038: net/ss5: Fix missing @sample(s) in plist
Use DISTVERSION, remove extra file listing in plist

@tobik Thanks, taught me a few things here

Seems this is no longer needed? Just seen a commit of one similar

tobik commandeered this revision.
tobik abandoned this revision.

Seems this is no longer needed? Just seen a commit of one similar

Looks like it. Fixed in rP479021.