multimedia/gxine: Remove dependency that no longer exists, other cleanup

[ndowens_yahoo.com]

Summary

Remove dependency that no longer exists, and may not be needed
Changed a few OPTION switches
General clean up

[ndowens_yahoo.com]

Updating D16978: multimedia/gxine
Add NLS knob to remove gettext as a must dep

[mat]

multimedia/gxine/Makefile

26

This is probably a bad idea.

27–28

Most of this would be USES=localbase

34–35

Part of this should be:

GNOME_CONFIGURE_WITH=  dbus

40

DESCs should happen earlier, See Chapter 15. Order of Variables in Port Makefiles.

56–60

You could probably fold those two commands into one.

[tobik]

multimedia/gxine/Makefile

14

LICENSE_FILE (no S at the end)

26

I feel like this is a problem that must be fixed in libxine and not worked around in every consumer.

I don't understand why compiling gxine with -fPIC fixes linking to libxine with lld.

28

I don't think -lm is needed anymore.

33–35

I am wondering if this does anything without GNOME screensaver running or if it is useless without it?

--without-dbus          disable dbus support (for GNOME screensaver)

55–60

logo.jpg is already being installed. No need to do it manually. gxine now uses logo.jpg since the libxine update, so logo.mpv is not needed anymore. Let's drop post-install completely.

[ndowens_yahoo.com]

multimedia/gxine/Makefile

26

Ed Maste replied to what I figured out that fPIC works around linker issue
@tobik @mat
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230994

LLDunsafe didn’t work nor adding the ldflags Ed said is medium

27–28

Was thinking about removing before posting here but didn’t know what -1m was for

33–35

I have no idea myself. I don’t use gnome and I don’t understand how a media player would even need screensaver dep. IIRC when I use to use gnome stuff I felt as gnome apps relied on dbus, but I could be wrong

[ndowens_yahoo.com]

Updating D16978: multimedia/gxine: Remove dependency that no longer exists, other cleanup
Fix typo in license file
remove cpp and ldflags
remove post-install block

[tobik]

multimedia/gxine/Makefile

26

LLDunsafe didn’t work

?

Of course LLD_UNSAFE works here or we wouldn't have been able to build gxine on 12.0/amd64 at all previously.

[ndowens_yahoo.com]

multimedia/gxine/Makefile

26

Retying but I do believe I was getting linker issues with it

[tobik]

multimedia/gxine/Makefile

33–35

I say remove it in that case. The option has been broken for 4 years (when gnome-screensaver was removed) and nobody has complained so I doubt anybody cares about it.

When you remove it make sure to append --disable-integration-wizard --without-dbus to CONFIGURE_ARGS in lieu of GNOME_CONFIGURE_OFF.

[ndowens_yahoo.com]

Updating D16978: multimedia/gxine: Remove dependency that no longer exists, other cleanup
Re-add lld_unsafe
Remove gnome option

[tobik]

Why did you abandon this?

[ndowens_yahoo.com]

In D16978#363146, @tobik wrote:

Why did you abandon this?

For some reason, thought it was commited along with the update with libxine :) But reclaimed

[ndowens_yahoo.com]

@tobik As you may know, I can't commit :)

[tobik]

In D16978#363397, @ndowens_yahoo.com wrote:

@tobik As you may know, I can't commit :)

Yeah, I know. Please do not ping me after only a couple of days though. The review is barely even a week old and hardly urgent.

In general it's also a good idea to open a corresponding bug on Bugzilla for every review, so that others can take care of it too. Phabricator is not a patch queue.