Page MenuHomeFreeBSD
Differential D16753

Simplify the EFI delay() function by calling BS->Stall().
ClosedPublic
Actions

Authored by bcran on Aug 16 2018, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 9:06 AM
Unknown Object (File)
Fri, Apr 12, 8:14 AM
Unknown Object (File)
Mar 18 2024, 6:05 AM
Unknown Object (File)
Mar 15 2024, 11:14 PM
Unknown Object (File)
Feb 23 2024, 11:43 AM
Unknown Object (File)
Feb 23 2024, 11:43 AM
Unknown Object (File)
Feb 23 2024, 11:43 AM
Unknown Object (File)
Feb 23 2024, 11:30 AM
View All 33 Files
Subscribers
None

Details

Reviewers
imp
kevans
manu
eadler
Commits
rS339796: Simplify the EFI delay() function by calling BS->Stall()
Test Plan

Tested on Qemu 2.12.0-rc3 with OVMF.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bcran created this revision.Aug 16 2018, 7:13 PM
Harbormaster completed remote builds in B18865: Diff 46794.Aug 16 2018, 7:13 PM
bcran added reviewers: kevans, manu.Aug 17 2018, 1:21 AM
bcran added a reviewer: eadler.
imp requested changes to this revision.Aug 17 2018, 2:30 AM
imp added inline comments.
stand/efi/libefi/delay.c
36 ↗(On Diff #46794)

When was this function added to the UEFI standard? If it's too new, then you'll need to provide a fallback...

This revision now requires changes to proceed.Aug 17 2018, 2:30 AM
bcran added inline comments.Aug 17 2018, 2:42 AM
stand/efi/libefi/delay.c
36 ↗(On Diff #46794)

It's in UEFI 2.0 from 2006, and EFI 1.10 from 2002.

imp accepted this revision.Aug 17 2018, 2:42 AM
This revision is now accepted and ready to land.Aug 17 2018, 2:42 AM
bcran added a comment.Sep 14 2018, 1:01 AM

I've now tested the change on an ARM64 Overdrive 1000, an EFI 1.10 MacBook Pro from 2007, and a ThinkPad T530.

manu accepted this revision.Sep 14 2018, 7:02 AM

I haven't test on u-boot but the function is defined (https://elixir.bootlin.com/u-boot/latest/source/lib/efi_loader/efi_boottime.c#L1938) so ok for me.

imp added a comment.Sep 14 2018, 9:07 PM

This year's award for going above and beyond in testing goes to...

manu added a comment.Sep 14 2018, 10:36 PM
In D16753#366156, @imp wrote:

This year's award for going above and beyond in testing goes to...

Tested with U-Boot 2018.07 (current in ports) and upcoming 2018.09 :)

Closed by commit rS339796: Simplify the EFI delay() function by calling BS->Stall() (authored by bcran). · Explain WhyOct 26 2018, 9:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
stand/
efi/
libefi/
12 lines

Diff 49670

View Options

head/stand/efi/libefi/delay.c

Loading...