devel/radare2: Update to 2.8.0
ClosedPublic
Actions

Authored by manu on Aug 10 2018, 10:15 AM.

Details

Reviewers

Commits

rP476979: devel/radare2: Update to 2.8.0

Summary

While here, unbreak on arm64
This was broken because of the debugger part of radare2.
Those patches fix that even if the debugger still doesn't work
due to lack of some ptrace function in the FreeBSD aarch64 port.
The patches were submitted and commited upstream.

Test Plan

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Aug 10 2018, 10:15 AM

Herald added subscribers: Contributor Reviewers (ports), mat, emaste, andrew. · View Herald TranscriptAug 10 2018, 10:15 AM

Harbormaster completed remote builds in B18694: Diff 46503.Aug 10 2018, 10:15 AM

manu added a reviewer: mizhka.Aug 10 2018, 11:52 AM

mat added inline comments.Aug 10 2018, 12:16 PM

devel/radare2/Makefile
5 ↗	(On Diff #46503)	Not needed.

manu added inline comments.Aug 10 2018, 12:34 PM

devel/radare2/Makefile
5 ↗	(On Diff #46503)	Why ? Because no aarch64 package was generated before ?

manu added inline comments.Aug 10 2018, 12:37 PM

devel/radare2/Makefile
5 ↗	(On Diff #46503)	Ok found the reason explain in the porters handbook.

Remove unneeded PORTREVISION

Harbormaster completed remote builds in B18695: Diff 46510.Aug 10 2018, 12:39 PM

manu marked an inline comment as done.Aug 10 2018, 12:39 PM

linimon added a subscriber: linimon.Aug 10 2018, 11:27 PM

Hi @manu ,

Many thanks for the patch!

Patch looks good and thanks for upstream submitting.
Port version is 2.7.0, the actual version is 2.8, yours is 2.6.9. I suppose it's better to fix version discrepancy and use 2.8.0. Could you please update patch?

Merci bien! ;)

In D16656#354231, @mizhka_gmail.com wrote:

Hi @manu ,

Many thanks for the patch!

Patch looks good and thanks for upstream submitting.
Port version is 2.7.0, the actual version is 2.8, yours is 2.6.9. I suppose it's better to fix version discrepancy and use 2.8.0. Could you please update patch?

Merci bien! ;)

Right, I had an old ports tree on my arm64 box.
I'll go ahead and update to 2.8.0 and check if everything is ok.

manu updated this revision to Diff 46589.Aug 12 2018, 5:06 AM

manu retitled this revision from devel/radare2: Unbreak on arm64 to devel/radare2: Update to 2.8.0.

manu edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B18742: Diff 46589.Aug 12 2018, 5:07 AM

mizhka accepted this revision.Aug 12 2018, 5:38 AM

This revision is now accepted and ready to land.Aug 12 2018, 5:38 AM

Closed by commit rP476979: devel/radare2: Update to 2.8.0 (authored by manu). · Explain WhyAug 12 2018, 8:40 AM

This revision was automatically updated to reflect the committed changes.