Page MenuHomeFreeBSD

Add signelf utility
Needs ReviewPublic

Authored by eric_metricspace.net on Aug 2 2018, 1:48 AM.

Details

Reviewers
None
Group Reviewers
manpages
Summary

The signelf utility is a batch-signer for creating and verifying signed ELF binaries. This is a component of the proposed trust infrastructure.

Note: this review is intended to allow for commentary on the ongoing work, not to imply that this change should be committed anytime soon. It would not make much sense to commit this utility without other trust components in place.

Test Plan

This utility was tested with PKCS#7 functions in place, but these have been replaced with CMS variants. It can be tested relatively simply by signing and verifying a group of shared objects or executables.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste added a subscriber: emaste.Aug 2 2018, 2:33 PM
bcr added a subscriber: bcr.Aug 2 2018, 4:59 PM

Can you run textproc/igor and "mandoc -Tlint" on the man pages and see what they spit out in terms of error messages? From a quick browse, I could see a few sentences that need to have a line break after the sentence stop. These tools can tell you where.

Thanks for working on this feature!

linimon retitled this revision from Add signelf utility to libelf: Add signelf utility.Aug 2 2018, 9:54 PM
emaste retitled this revision from libelf: Add signelf utility to Add signelf utility.Aug 3 2018, 2:17 AM
emaste added a subscriber: linimon.

@linimon I removed the "libelf" prefix; this review includes a change to libelf (which is actually the dependency D10487 and ought not be included here) but this change is not a "libelf" change.

linimon removed a subscriber: linimon.Fri, May 10, 12:10 AM