Page MenuHomeFreeBSD

Add devel/hs-fortran-src port - a library for lexing and parsing Fortran source code.
ClosedPublic

Authored by arrowd on Jul 31 2018, 8:59 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arrowd created this revision.Jul 31 2018, 8:59 AM
mat added a subscriber: mat.Jul 31 2018, 9:49 AM
mat added inline comments.
devel/hs-GenericPretty/Makefile
1 ↗(On Diff #46062)

Missing the header.

devel/hs-GenericPretty/pkg-descr
4 ↗(On Diff #46062)

Remove.

devel/hs-fortran-src/Makefile
1 ↗(On Diff #46062)

Missing header.

devel/hs-fortran-src/pkg-descr
4 ↗(On Diff #46062)

Remove.

arrowd added inline comments.Jul 31 2018, 8:57 PM
devel/hs-GenericPretty/Makefile
1 ↗(On Diff #46062)

What header? $ FreeBSD $?

devel/hs-GenericPretty/pkg-descr
4 ↗(On Diff #46062)

Newline or WWW line?

tcberner added inline comments.Aug 1 2018, 5:29 AM
devel/hs-GenericPretty/Makefile
1 ↗(On Diff #46062)

Yup, that one is always required, see sample Makefile

devel/hs-GenericPretty/pkg-descr
4 ↗(On Diff #46062)

new line :)

When adding new [or removing] ports, you always need to carry the changes in the category Makefile's SUBDIR list.

tcberner added inline comments.Aug 1 2018, 5:32 AM
devel/hs-GenericPretty/Makefile
3 ↗(On Diff #46062)

^ new ports should not have a portrevision

6 ↗(On Diff #46062)

^ is that the correct email? :D

mat added inline comments.Aug 1 2018, 7:43 AM
devel/hs-GenericPretty/pkg-descr
4 ↗(On Diff #46062)

My comment is related to line 4, so, yes, blank line.

arrowd updated this revision to Diff 46122.Aug 1 2018, 8:54 AM
arrowd marked 11 inline comments as done.

Address comments.

arrowd added inline comments.Aug 1 2018, 8:54 AM
devel/hs-GenericPretty/Makefile
6 ↗(On Diff #46062)

Yes, the port was submitted by other guy.

mat added inline comments.Aug 1 2018, 9:05 AM
devel/hs-GenericPretty/pkg-descr
1 ↗(On Diff #46122)

pkg-descr must be a few lines long, at least a paragraph.

devel/hs-fortran-src/pkg-descr
1 ↗(On Diff #46122)

I do not think anlyses is a word.
Also, pkg-descr must be a few lines long, at least a paragraph.

tcberner added inline comments.Aug 1 2018, 12:00 PM
devel/hs-fortran-src/pkg-descr
1 ↗(On Diff #46122)

I had the same reaction -- it's the description of the thingy on it's website.

Further down they spell it more conventionally as analyses.

tcberner requested changes to this revision.Aug 1 2018, 12:01 PM

You're still missing the entries in devel/Makefile.

This revision now requires changes to proceed.Aug 1 2018, 12:01 PM
arrowd updated this revision to Diff 46138.Aug 1 2018, 6:04 PM
arrowd marked 2 inline comments as done.

Address comments.

tcberner accepted this revision.Aug 1 2018, 7:02 PM

Looks good to me.

This revision is now accepted and ready to land.Aug 1 2018, 7:02 PM
This revision was automatically updated to reflect the committed changes.