release: arm: Enable multicons for arm64
ClosedPublic
Actions

Authored by manu on Jul 27 2018, 5:39 PM.

Details

Reviewers

lwhsu
gjb

Group Reviewers

releng

Commits

rS336999: release: arm: Enable multicons for arm64

Summary

Since we have now EFI framebuffer enabled for ARM64 if we boot on a board
with an screen, u-boot will set up a EFI GOP framebuffer and we won't boot
using the serial console.
Also on RPI3 the firmware always setup the framebuffer area resulting in u-boot
always setup the EFI GOP and FreeBSD never using the serial console.

Reported by: lwshu

Test Plan

Build release image with the change and tested on RPI3 without an hdmi screen attached.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18393
Build 18108: arc lint + arc unit

Event Timeline

manu created this revision.Jul 27 2018, 5:39 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptJul 27 2018, 5:39 PM

Harbormaster completed remote builds in B18373: Diff 45917.Jul 27 2018, 5:39 PM

LGTM, although I don't have a src bit right now. :-)

This revision is now accepted and ready to land.Jul 27 2018, 5:43 PM

manu added inline comments.Jul 27 2018, 11:25 PM

release/tools/arm.subr
131	It needs EMBEDDED_TARGET_ARCH, running build to see if everything is ok.

manu updated this revision to Diff 45935.Jul 28 2018, 2:43 AM

manu edited the test plan for this revision. (Show Details)

This revision now requires review to proceed.Jul 28 2018, 2:43 AM

Harbormaster completed remote builds in B18388: Diff 45935.Jul 28 2018, 2:43 AM

Add boot_serial too so all kernel messages appears on the serial console.

Harbormaster completed remote builds in B18393: Diff 45951.Jul 28 2018, 3:03 PM

imp added inline comments.Jul 28 2018, 7:33 PM

release/tools/arm.subr
131	We could also do this for arm, no? Those systems with video will see it, and it won't hurt those w/o.
140	This is good.

manu added inline comments.Jul 28 2018, 7:37 PM

release/tools/arm.subr
131	It's unneeded as I only implemented efifb for arm64 due to pmap difference between arm and arm64.

imp added inline comments.Jul 28 2018, 7:56 PM

release/tools/arm.subr
131	I thought we had other frame buffer support for RPi, Allwinner and BBB, which would benefit from this as well...

manu added inline comments.Jul 28 2018, 8:01 PM

release/tools/arm.subr
131	Allwinner is dead because nobody care to push the (wrong) dts binding we hacked at the time. For RPI and BBB those are VT driver that come up later in the boot process. This is not what this review is attempting to fix (I don't even know if it makes a difference on those plateform).

gjb accepted this revision.Jul 31 2018, 7:04 PM

This revision is now accepted and ready to land.Jul 31 2018, 7:04 PM

Closed by commit rS336999: release: arm: Enable multicons for arm64 (authored by manu). · Explain WhyJul 31 2018, 7:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

release/

tools/

arm.subr

14 lines

Diff 45951

View Options

release: arm: Enable multicons for arm64ClosedPublicActions