Improve --strip-trailing-cr handling
ClosedPublic
Actions

Authored by delphij on Jul 26 2018, 8:45 AM.

Tags

None

Referenced Files

	F152831483: D16451.id.diff
	Fri, Apr 17, 9:51 AM

	Unknown Object (File)
	Wed, Apr 15, 4:37 PM

	Unknown Object (File)
	Wed, Apr 15, 2:10 PM

	Unknown Object (File)
	Wed, Apr 15, 12:35 PM

	Unknown Object (File)
	Wed, Apr 15, 7:52 AM

	Unknown Object (File)
	Sat, Apr 11, 8:00 PM

	Unknown Object (File)
	Fri, Apr 10, 11:33 PM

	Unknown Object (File)
	Mon, Apr 6, 5:26 PM

View All Files

Subscribers

allanjude

imp

Details

Reviewers

ngie
bapt
fbsd-phab_maskray.me

Commits

rS336754: Improve --strip-trailing-cr handling:

Summary

Improve --strip-trailing-cr handling:

Advance ctold for f1 and ctnew for f2
ungetc() if the character is unexpected
Don't break early when we hit the combination on one side

PR: 230049

Test Plan

kyua test -k /usr/tests/Kyuafile usr.bin/diff

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.Jul 26 2018, 8:45 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 26 2018, 8:45 AM

Harbormaster completed remote builds in B18345: Diff 45864.Jul 26 2018, 8:45 AM

bapt accepted this revision.Jul 26 2018, 9:00 AM

This revision is now accepted and ready to land.Jul 26 2018, 9:00 AM

fbsd-phab_maskray.me accepted this revision.Jul 27 2018, 2:51 AM

fbsd-phab_maskray.me added a comment.Jul 27 2018, 3:16 AM

This comment was removed by allanjude.

Closed by commit rS336754: Improve --strip-trailing-cr handling: (authored by delphij). · Explain WhyJul 27 2018, 5:21 AM

This revision was automatically updated to reflect the committed changes.

allanjude added a subscriber: allanjude.Jul 29 2018, 6:49 PM

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

diff/

diffreg.c

13 lines

tests/

diff_test.sh

11 lines

Diff 45899

View Options

head/usr.bin/diff/diffreg.c