Page MenuHomeFreeBSD

top(1): rollback r335836
ClosedPublic

Authored by daichi on Jul 10 2018, 1:03 AM.

Details

Reviewers
hrs
jilles
eadler
gnn
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rS336160: top(1): rollback r335836
Summary

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

daichi created this revision.Jul 10 2018, 1:03 AM
hrs requested changes to this revision.Jul 10 2018, 1:16 AM

Please split this changes into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. A single commit including the both is confusing.

This revision now requires changes to proceed.Jul 10 2018, 1:16 AM
daichi updated this revision to Diff 45091.Jul 10 2018, 1:38 AM
daichi retitled this revision from top(1): support multibyte characters in ARGV array depending on LC_CTYPE, not limited to UTF-8 to top(1): rollback r335836.
daichi edited the summary of this revision. (Show Details)
daichi edited the test plan for this revision. (Show Details)

Following the advice of hrs, splitted into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. I changed this review to rollback.

hrs accepted this revision.Jul 10 2018, 3:32 AM

Reverting a change does not need any approval or review. Please document the reason in the commit log instead of just saying "rollback".

This revision is now accepted and ready to land.Jul 10 2018, 3:32 AM
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: Restricted Owners Package.Jul 10 2018, 3:50 AM