Differential D16060

Maintenance's commit of Microsemi smartpqi driver
ClosedPublic
Actions

Authored by deepak.ukey_microsemi.com on Jun 29 2018, 11:38 AM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Dec 2, 7:07 PM

	Unknown Object (File)
	Tue, Dec 2, 3:30 AM

	Unknown Object (File)
	Fri, Nov 21, 4:28 PM

	Unknown Object (File)
	Thu, Nov 20, 5:38 PM

	Unknown Object (File)
	Thu, Nov 20, 5:26 PM

	Unknown Object (File)
	Thu, Nov 20, 5:24 PM

	Unknown Object (File)
	Thu, Nov 20, 5:16 PM

	Unknown Object (File)
	Thu, Nov 20, 5:08 PM

Subscribers

Details

Reviewers

sbruno
scottl
mav

Commits

rS336201: smartpqi(4):

Summary

This maintenance commit contains fixes and features for Microsemi's smartpqi module.

Test Plan

Smartpqi driver is tested and qualified by internal quality assurance team.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deepak.ukey_microsemi.com created this revision.Jun 29 2018, 11:38 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 29 2018, 11:38 AM

sbruno added reviewers: scottl, mav.Jul 3 2018, 3:57 PM

On a quick look I spotted number of style issues you may fix.

sys/dev/smartpqi/smartpqi_defines.h
909 ↗	(On Diff #44630)	This looks like a null change, but if you wish so, so be it.
920 ↗	(On Diff #44630)	Here would be good to add braces around rcb on the rigth side.
948 ↗	(On Diff #44630)	Here should be tab after define. Also it may be not very good to change flags meaning without significant reason.
sys/dev/smartpqi/smartpqi_discovery.c
48 ↗	(On Diff #44630)	Here extra tabs.
sys/dev/smartpqi/smartpqi_init.c
568 ↗	(On Diff #44630)	Extra tabs.
579 ↗	(On Diff #44630)	Something happened to formatting.
681 ↗	(On Diff #44630)	FreeBSD style(9) recommends to wrap the line before the function name and before the opening curly bracket. And also some extra tabs.
762 ↗	(On Diff #44630)	Here some mess with tabs/spaces.
sys/dev/smartpqi/smartpqi_mem.c
61 ↗	(On Diff #44630)	Very "useful" function. ;)

Incorporated the changes according to review comments.

I have no objections.

This revision is now accepted and ready to land.Jul 9 2018, 8:18 PM

sbruno accepted this revision.Jul 11 2018, 4:42 PM

Closed by commit rS336201: smartpqi(4): (authored by sbruno). · Explain WhyJul 11 2018, 4:44 PM

This revision was automatically updated to reflect the committed changes.

Please stop adding redundant prototypes for the same function — it breaks the GCC build. The tagged lines below are not exhaustive.

head/sys/dev/smartpqi/smartpqi_prototypes.h
143	This one's got a dupe too
144	E.g., this is defined again 100 lines lower in the same header. Why???
145	Ditto.
241–242	We don't need both

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

smartpqi/

5 lines

smartpqi_defines.h

42 lines

smartpqi_discovery.c

115 lines

smartpqi_event.c

6 lines

smartpqi_helper.c

23 lines

smartpqi_init.c

139 lines

smartpqi_intr.c

4 lines

smartpqi_ioctl.c

9 lines

smartpqi_main.c

21 lines

14 lines

smartpqi_prototypes.h

18 lines

smartpqi_queue.c

5 lines

smartpqi_request.c

5 lines

90 lines

smartpqi_structures.h

9 lines

Diff 45177

head/sys/dev/smartpqi/smartpqi_cam.c

Loading...

head/sys/dev/smartpqi/smartpqi_defines.h

Loading...

head/sys/dev/smartpqi/smartpqi_discovery.c

Loading...

head/sys/dev/smartpqi/smartpqi_event.c

Loading...

head/sys/dev/smartpqi/smartpqi_helper.c

Loading...

head/sys/dev/smartpqi/smartpqi_init.c

Loading...

head/sys/dev/smartpqi/smartpqi_intr.c

Loading...

head/sys/dev/smartpqi/smartpqi_ioctl.c

Loading...

head/sys/dev/smartpqi/smartpqi_main.c

Loading...

head/sys/dev/smartpqi/smartpqi_mem.c

Loading...

head/sys/dev/smartpqi/smartpqi_prototypes.h

Loading...

head/sys/dev/smartpqi/smartpqi_queue.c

Loading...

head/sys/dev/smartpqi/smartpqi_request.c

Loading...

head/sys/dev/smartpqi/smartpqi_sis.c

Loading...

head/sys/dev/smartpqi/smartpqi_structures.h

Loading...