This maintenance commit contains fixes and features for Microsemi's smartpqi module.
On a quick look I spotted number of style issues you may fix.
|909 ↗||(On Diff #44630)|
This looks like a null change, but if you wish so, so be it.
|920 ↗||(On Diff #44630)|
Here would be good to add braces around rcb on the rigth side.
|948 ↗||(On Diff #44630)|
Here should be tab after define. Also it may be not very good to change flags meaning without significant reason.
|48 ↗||(On Diff #44630)|
Here extra tabs.
|568 ↗||(On Diff #44630)|
|579 ↗||(On Diff #44630)|
Something happened to formatting.
|681 ↗||(On Diff #44630)|
FreeBSD style(9) recommends to wrap the line before the function name and before the opening curly bracket. And also some extra tabs.
|762 ↗||(On Diff #44630)|
Here some mess with tabs/spaces.
|61 ↗||(On Diff #44630)|
Very "useful" function. ;)
Please stop adding redundant prototypes for the same function — it breaks the GCC build. The tagged lines below are not exhaustive.
This one's got a dupe too
E.g., this is defined again 100 lines lower in the same header. Why???
We don't need both