Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each.
Needs ReviewPublic
Actions

Authored by bz on Jun 19 2018, 4:36 PM.

Details

Reviewers

jamie
kib
jhb

Summary

Implement "global" process (and zombie) lists loops
iterating over all vps instances and all processes in each
(similarly to what was done for vnets).

There are a few per-vps cases which have been marked.

Pointed out by: kib
Sponsored by: iXsystems, Inc.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17446
Build 17278: arc lint + arc unit

Event Timeline

bz created this revision.Jun 19 2018, 4:36 PM

Herald added a subscriber: emaste. · View Herald TranscriptJun 19 2018, 4:36 PM

Harbormaster completed remote builds in B17446: Diff 44079.Jun 19 2018, 4:36 PM

I'll try to get some of the whitespace changes (using sub-functions for highly indented code, etc) out of this patch and into head separately to make it easier to review this one.

bz mentioned this in D15570: Virtualization of basic variables and locks for jail+vps..Jun 19 2018, 4:41 PM

Merge branch 'p1' into p2

Herald added a subscriber: ae. · View Herald TranscriptJul 11 2018, 2:54 PM

Harbormaster completed remote builds in B17981: Diff 45165.Jul 11 2018, 2:54 PM

Looks like there was an unlock lost during the merge.

Harbormaster completed remote builds in B17982: Diff 45168.Jul 11 2018, 3:48 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_current.c

25 lines

ddb/

db_command.c

19 lines

db_ps.c

21 lines

db_thread.c

2 lines

dev/

filemon/

filemon.c

29 lines

hwpmc/

hwpmc_mod.c

24 lines

fs/

pseudofs/

pseudofs_vnops.c

5 lines

i386/

ibcs2/

ibcs2_sysvec.c

19 lines

kern/

19 lines

1 line

207 lines

32 lines

211 lines

1 line

2 lines

4 lines

71 lines

183 lines

147 lines

132 lines

2 lines

2 lines

21 lines

8 lines

26 lines

27 lines

vm/

66 lines

25 lines

139 lines

322 lines

Diff 44079

View Options

sys/compat/linuxkpi/common/src/linux_current.c

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
* iBCS2 msgsys call		* iBCS2 msgsys call
*/		*/

static void		static void
cvt_msqid2imsqid(bp, ibp)		cvt_msqid2imsqid(bp, ibp)
struct msqid_ds *bp;		struct msqid_ds *bp;
struct ibcs2_msqid_ds *ibp;		struct ibcs2_msqid_ds *ibp;
{		{
		memset(ibp, 0, sizeof(*ibp));
cvt_perm2iperm(&bp->msg_perm, &ibp->msg_perm);		cvt_perm2iperm(&bp->msg_perm, &ibp->msg_perm);
ibp->msg_first = bp->msg_first;
ibp->msg_last = bp->msg_last;
ibp->msg_cbytes = (u_short)bp->msg_cbytes;		ibp->msg_cbytes = (u_short)bp->msg_cbytes;
ibp->msg_qnum = (u_short)bp->msg_qnum;		ibp->msg_qnum = (u_short)bp->msg_qnum;
ibp->msg_qbytes = (u_short)bp->msg_qbytes;		ibp->msg_qbytes = (u_short)bp->msg_qbytes;
ibp->msg_lspid = (u_short)bp->msg_lspid;		ibp->msg_lspid = (u_short)bp->msg_lspid;
ibp->msg_lrpid = (u_short)bp->msg_lrpid;		ibp->msg_lrpid = (u_short)bp->msg_lrpid;
ibp->msg_stime = bp->msg_stime;		ibp->msg_stime = bp->msg_stime;
ibp->msg_rtime = bp->msg_rtime;		ibp->msg_rtime = bp->msg_rtime;
ibp->msg_ctime = bp->msg_ctime;		ibp->msg_ctime = bp->msg_ctime;
return;		return;
}		}

static void		static void
cvt_imsqid2msqid(ibp, bp)		cvt_imsqid2msqid(ibp, bp)
struct ibcs2_msqid_ds *ibp;		struct ibcs2_msqid_ds *ibp;
struct msqid_ds *bp;		struct msqid_ds *bp;
{		{
cvt_iperm2perm(&ibp->msg_perm, &bp->msg_perm);		cvt_iperm2perm(&ibp->msg_perm, &bp->msg_perm);
bp->msg_first = ibp->msg_first;
bp->msg_last = ibp->msg_last;
bp->msg_cbytes = ibp->msg_cbytes;		bp->msg_cbytes = ibp->msg_cbytes;
bp->msg_qnum = ibp->msg_qnum;		bp->msg_qnum = ibp->msg_qnum;
bp->msg_qbytes = ibp->msg_qbytes;		bp->msg_qbytes = ibp->msg_qbytes;
bp->msg_lspid = ibp->msg_lspid;		bp->msg_lspid = ibp->msg_lspid;
bp->msg_lrpid = ibp->msg_lrpid;		bp->msg_lrpid = ibp->msg_lrpid;
bp->msg_stime = ibp->msg_stime;		bp->msg_stime = ibp->msg_stime;
bp->msg_rtime = ibp->msg_rtime;		bp->msg_rtime = ibp->msg_rtime;
bp->msg_ctime = ibp->msg_ctime;		bp->msg_ctime = ibp->msg_ctime;
▲ Show 20 Lines • Show All 172 Lines • ▼ Show 20 Lines	struct ibcs2_ipc_perm *ipp;
ipp->key = pp->key;		ipp->key = pp->key;
}		}

static void		static void
cvt_semid2isemid(bp, ibp)		cvt_semid2isemid(bp, ibp)
struct semid_ds *bp;		struct semid_ds *bp;
struct ibcs2_semid_ds *ibp;		struct ibcs2_semid_ds *ibp;
{		{
		memset(ibp, 0, sizeof(*ibp);
cvt_perm2iperm(&bp->sem_perm, &ibp->sem_perm);		cvt_perm2iperm(&bp->sem_perm, &ibp->sem_perm);
ibp->sem_base = (struct ibcs2_sem *)bp->sem_base;
ibp->sem_nsems = bp->sem_nsems;		ibp->sem_nsems = bp->sem_nsems;
ibp->sem_otime = bp->sem_otime;		ibp->sem_otime = bp->sem_otime;
ibp->sem_ctime = bp->sem_ctime;		ibp->sem_ctime = bp->sem_ctime;
return;		return;
}		}

static void		static void
cvt_isemid2semid(ibp, bp)		cvt_isemid2semid(ibp, bp)
struct ibcs2_semid_ds *ibp;		struct ibcs2_semid_ds *ibp;
struct semid_ds *bp;		struct semid_ds *bp;
{		{
cvt_iperm2perm(&ibp->sem_perm, &bp->sem_perm);		cvt_iperm2perm(&ibp->sem_perm, &bp->sem_perm);
bp->sem_base = (struct sem *)ibp->sem_base;
bp->sem_nsems = ibp->sem_nsems;		bp->sem_nsems = ibp->sem_nsems;
bp->sem_otime = ibp->sem_otime;		bp->sem_otime = ibp->sem_otime;
bp->sem_ctime = ibp->sem_ctime;		bp->sem_ctime = ibp->sem_ctime;
return;		return;
}		}

struct ibcs2_semctl_args {		struct ibcs2_semctl_args {
int what;		int what;
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines

View Options

sys/ddb/db_command.c

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
* iBCS2 msgsys call		* iBCS2 msgsys call
*/		*/

static void		static void
cvt_msqid2imsqid(bp, ibp)		cvt_msqid2imsqid(bp, ibp)
struct msqid_ds *bp;		struct msqid_ds *bp;
struct ibcs2_msqid_ds *ibp;		struct ibcs2_msqid_ds *ibp;
{		{
		memset(ibp, 0, sizeof(*ibp));
cvt_perm2iperm(&bp->msg_perm, &ibp->msg_perm);		cvt_perm2iperm(&bp->msg_perm, &ibp->msg_perm);
ibp->msg_first = bp->msg_first;
ibp->msg_last = bp->msg_last;
ibp->msg_cbytes = (u_short)bp->msg_cbytes;		ibp->msg_cbytes = (u_short)bp->msg_cbytes;
ibp->msg_qnum = (u_short)bp->msg_qnum;		ibp->msg_qnum = (u_short)bp->msg_qnum;
ibp->msg_qbytes = (u_short)bp->msg_qbytes;		ibp->msg_qbytes = (u_short)bp->msg_qbytes;
ibp->msg_lspid = (u_short)bp->msg_lspid;		ibp->msg_lspid = (u_short)bp->msg_lspid;
ibp->msg_lrpid = (u_short)bp->msg_lrpid;		ibp->msg_lrpid = (u_short)bp->msg_lrpid;
ibp->msg_stime = bp->msg_stime;		ibp->msg_stime = bp->msg_stime;
ibp->msg_rtime = bp->msg_rtime;		ibp->msg_rtime = bp->msg_rtime;
ibp->msg_ctime = bp->msg_ctime;		ibp->msg_ctime = bp->msg_ctime;
return;		return;
}		}

static void		static void
cvt_imsqid2msqid(ibp, bp)		cvt_imsqid2msqid(ibp, bp)
struct ibcs2_msqid_ds *ibp;		struct ibcs2_msqid_ds *ibp;
struct msqid_ds *bp;		struct msqid_ds *bp;
{		{
cvt_iperm2perm(&ibp->msg_perm, &bp->msg_perm);		cvt_iperm2perm(&ibp->msg_perm, &bp->msg_perm);
bp->msg_first = ibp->msg_first;
bp->msg_last = ibp->msg_last;
bp->msg_cbytes = ibp->msg_cbytes;		bp->msg_cbytes = ibp->msg_cbytes;
bp->msg_qnum = ibp->msg_qnum;		bp->msg_qnum = ibp->msg_qnum;
bp->msg_qbytes = ibp->msg_qbytes;		bp->msg_qbytes = ibp->msg_qbytes;
bp->msg_lspid = ibp->msg_lspid;		bp->msg_lspid = ibp->msg_lspid;
bp->msg_lrpid = ibp->msg_lrpid;		bp->msg_lrpid = ibp->msg_lrpid;
bp->msg_stime = ibp->msg_stime;		bp->msg_stime = ibp->msg_stime;
bp->msg_rtime = ibp->msg_rtime;		bp->msg_rtime = ibp->msg_rtime;
bp->msg_ctime = ibp->msg_ctime;		bp->msg_ctime = ibp->msg_ctime;
▲ Show 20 Lines • Show All 172 Lines • ▼ Show 20 Lines	struct ibcs2_ipc_perm *ipp;
ipp->key = pp->key;		ipp->key = pp->key;
}		}

static void		static void
cvt_semid2isemid(bp, ibp)		cvt_semid2isemid(bp, ibp)
struct semid_ds *bp;		struct semid_ds *bp;
struct ibcs2_semid_ds *ibp;		struct ibcs2_semid_ds *ibp;
{		{
		memset(ibp, 0, sizeof(*ibp);
cvt_perm2iperm(&bp->sem_perm, &ibp->sem_perm);		cvt_perm2iperm(&bp->sem_perm, &ibp->sem_perm);
ibp->sem_base = (struct ibcs2_sem *)bp->sem_base;
ibp->sem_nsems = bp->sem_nsems;		ibp->sem_nsems = bp->sem_nsems;
ibp->sem_otime = bp->sem_otime;		ibp->sem_otime = bp->sem_otime;
ibp->sem_ctime = bp->sem_ctime;		ibp->sem_ctime = bp->sem_ctime;
return;		return;
}		}

static void		static void
cvt_isemid2semid(ibp, bp)		cvt_isemid2semid(ibp, bp)
struct ibcs2_semid_ds *ibp;		struct ibcs2_semid_ds *ibp;
struct semid_ds *bp;		struct semid_ds *bp;
{		{
cvt_iperm2perm(&ibp->sem_perm, &bp->sem_perm);		cvt_iperm2perm(&ibp->sem_perm, &bp->sem_perm);
bp->sem_base = (struct sem *)ibp->sem_base;
bp->sem_nsems = ibp->sem_nsems;		bp->sem_nsems = ibp->sem_nsems;
bp->sem_otime = ibp->sem_otime;		bp->sem_otime = ibp->sem_otime;
bp->sem_ctime = ibp->sem_ctime;		bp->sem_ctime = ibp->sem_ctime;
return;		return;
}		}

struct ibcs2_semctl_args {		struct ibcs2_semctl_args {
int what;		int what;
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines

View Options

sys/ddb/db_ps.c

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
* iBCS2 msgsys call		* iBCS2 msgsys call
*/		*/

static void		static void
cvt_msqid2imsqid(bp, ibp)		cvt_msqid2imsqid(bp, ibp)
struct msqid_ds *bp;		struct msqid_ds *bp;
struct ibcs2_msqid_ds *ibp;		struct ibcs2_msqid_ds *ibp;
{		{
		memset(ibp, 0, sizeof(*ibp));
cvt_perm2iperm(&bp->msg_perm, &ibp->msg_perm);		cvt_perm2iperm(&bp->msg_perm, &ibp->msg_perm);
ibp->msg_first = bp->msg_first;
ibp->msg_last = bp->msg_last;
ibp->msg_cbytes = (u_short)bp->msg_cbytes;		ibp->msg_cbytes = (u_short)bp->msg_cbytes;
ibp->msg_qnum = (u_short)bp->msg_qnum;		ibp->msg_qnum = (u_short)bp->msg_qnum;
ibp->msg_qbytes = (u_short)bp->msg_qbytes;		ibp->msg_qbytes = (u_short)bp->msg_qbytes;
ibp->msg_lspid = (u_short)bp->msg_lspid;		ibp->msg_lspid = (u_short)bp->msg_lspid;
ibp->msg_lrpid = (u_short)bp->msg_lrpid;		ibp->msg_lrpid = (u_short)bp->msg_lrpid;
ibp->msg_stime = bp->msg_stime;		ibp->msg_stime = bp->msg_stime;
ibp->msg_rtime = bp->msg_rtime;		ibp->msg_rtime = bp->msg_rtime;
ibp->msg_ctime = bp->msg_ctime;		ibp->msg_ctime = bp->msg_ctime;
return;		return;
}		}

static void		static void
cvt_imsqid2msqid(ibp, bp)		cvt_imsqid2msqid(ibp, bp)
struct ibcs2_msqid_ds *ibp;		struct ibcs2_msqid_ds *ibp;
struct msqid_ds *bp;		struct msqid_ds *bp;
{		{
cvt_iperm2perm(&ibp->msg_perm, &bp->msg_perm);		cvt_iperm2perm(&ibp->msg_perm, &bp->msg_perm);
bp->msg_first = ibp->msg_first;
bp->msg_last = ibp->msg_last;
bp->msg_cbytes = ibp->msg_cbytes;		bp->msg_cbytes = ibp->msg_cbytes;
bp->msg_qnum = ibp->msg_qnum;		bp->msg_qnum = ibp->msg_qnum;
bp->msg_qbytes = ibp->msg_qbytes;		bp->msg_qbytes = ibp->msg_qbytes;
bp->msg_lspid = ibp->msg_lspid;		bp->msg_lspid = ibp->msg_lspid;
bp->msg_lrpid = ibp->msg_lrpid;		bp->msg_lrpid = ibp->msg_lrpid;
bp->msg_stime = ibp->msg_stime;		bp->msg_stime = ibp->msg_stime;
bp->msg_rtime = ibp->msg_rtime;		bp->msg_rtime = ibp->msg_rtime;
bp->msg_ctime = ibp->msg_ctime;		bp->msg_ctime = ibp->msg_ctime;
▲ Show 20 Lines • Show All 172 Lines • ▼ Show 20 Lines	struct ibcs2_ipc_perm *ipp;
ipp->key = pp->key;		ipp->key = pp->key;
}		}

static void		static void
cvt_semid2isemid(bp, ibp)		cvt_semid2isemid(bp, ibp)
struct semid_ds *bp;		struct semid_ds *bp;
struct ibcs2_semid_ds *ibp;		struct ibcs2_semid_ds *ibp;
{		{
		memset(ibp, 0, sizeof(*ibp);
cvt_perm2iperm(&bp->sem_perm, &ibp->sem_perm);		cvt_perm2iperm(&bp->sem_perm, &ibp->sem_perm);
ibp->sem_base = (struct ibcs2_sem *)bp->sem_base;
ibp->sem_nsems = bp->sem_nsems;		ibp->sem_nsems = bp->sem_nsems;
ibp->sem_otime = bp->sem_otime;		ibp->sem_otime = bp->sem_otime;
ibp->sem_ctime = bp->sem_ctime;		ibp->sem_ctime = bp->sem_ctime;
return;		return;
}		}

static void		static void
cvt_isemid2semid(ibp, bp)		cvt_isemid2semid(ibp, bp)
struct ibcs2_semid_ds *ibp;		struct ibcs2_semid_ds *ibp;
struct semid_ds *bp;		struct semid_ds *bp;
{		{
cvt_iperm2perm(&ibp->sem_perm, &bp->sem_perm);		cvt_iperm2perm(&ibp->sem_perm, &bp->sem_perm);
bp->sem_base = (struct sem *)ibp->sem_base;
bp->sem_nsems = ibp->sem_nsems;		bp->sem_nsems = ibp->sem_nsems;
bp->sem_otime = ibp->sem_otime;		bp->sem_otime = ibp->sem_otime;
bp->sem_ctime = ibp->sem_ctime;		bp->sem_ctime = ibp->sem_ctime;
return;		return;
}		}

struct ibcs2_semctl_args {		struct ibcs2_semctl_args {
int what;		int what;
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines

View Options

sys/ddb/db_thread.c

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
* iBCS2 msgsys call		* iBCS2 msgsys call
*/		*/

static void		static void
cvt_msqid2imsqid(bp, ibp)		cvt_msqid2imsqid(bp, ibp)
struct msqid_ds *bp;		struct msqid_ds *bp;
struct ibcs2_msqid_ds *ibp;		struct ibcs2_msqid_ds *ibp;
{		{
		memset(ibp, 0, sizeof(*ibp));
cvt_perm2iperm(&bp->msg_perm, &ibp->msg_perm);		cvt_perm2iperm(&bp->msg_perm, &ibp->msg_perm);
ibp->msg_first = bp->msg_first;
ibp->msg_last = bp->msg_last;
ibp->msg_cbytes = (u_short)bp->msg_cbytes;		ibp->msg_cbytes = (u_short)bp->msg_cbytes;
ibp->msg_qnum = (u_short)bp->msg_qnum;		ibp->msg_qnum = (u_short)bp->msg_qnum;
ibp->msg_qbytes = (u_short)bp->msg_qbytes;		ibp->msg_qbytes = (u_short)bp->msg_qbytes;
ibp->msg_lspid = (u_short)bp->msg_lspid;		ibp->msg_lspid = (u_short)bp->msg_lspid;
ibp->msg_lrpid = (u_short)bp->msg_lrpid;		ibp->msg_lrpid = (u_short)bp->msg_lrpid;
ibp->msg_stime = bp->msg_stime;		ibp->msg_stime = bp->msg_stime;
ibp->msg_rtime = bp->msg_rtime;		ibp->msg_rtime = bp->msg_rtime;
ibp->msg_ctime = bp->msg_ctime;		ibp->msg_ctime = bp->msg_ctime;
return;		return;
}		}

static void		static void
cvt_imsqid2msqid(ibp, bp)		cvt_imsqid2msqid(ibp, bp)
struct ibcs2_msqid_ds *ibp;		struct ibcs2_msqid_ds *ibp;
struct msqid_ds *bp;		struct msqid_ds *bp;
{		{
cvt_iperm2perm(&ibp->msg_perm, &bp->msg_perm);		cvt_iperm2perm(&ibp->msg_perm, &bp->msg_perm);
bp->msg_first = ibp->msg_first;
bp->msg_last = ibp->msg_last;
bp->msg_cbytes = ibp->msg_cbytes;		bp->msg_cbytes = ibp->msg_cbytes;
bp->msg_qnum = ibp->msg_qnum;		bp->msg_qnum = ibp->msg_qnum;
bp->msg_qbytes = ibp->msg_qbytes;		bp->msg_qbytes = ibp->msg_qbytes;
bp->msg_lspid = ibp->msg_lspid;		bp->msg_lspid = ibp->msg_lspid;
bp->msg_lrpid = ibp->msg_lrpid;		bp->msg_lrpid = ibp->msg_lrpid;
bp->msg_stime = ibp->msg_stime;		bp->msg_stime = ibp->msg_stime;
bp->msg_rtime = ibp->msg_rtime;		bp->msg_rtime = ibp->msg_rtime;
bp->msg_ctime = ibp->msg_ctime;		bp->msg_ctime = ibp->msg_ctime;
▲ Show 20 Lines • Show All 172 Lines • ▼ Show 20 Lines	struct ibcs2_ipc_perm *ipp;
ipp->key = pp->key;		ipp->key = pp->key;
}		}

static void		static void
cvt_semid2isemid(bp, ibp)		cvt_semid2isemid(bp, ibp)
struct semid_ds *bp;		struct semid_ds *bp;
struct ibcs2_semid_ds *ibp;		struct ibcs2_semid_ds *ibp;
{		{
		memset(ibp, 0, sizeof(*ibp);
cvt_perm2iperm(&bp->sem_perm, &ibp->sem_perm);		cvt_perm2iperm(&bp->sem_perm, &ibp->sem_perm);
ibp->sem_base = (struct ibcs2_sem *)bp->sem_base;
ibp->sem_nsems = bp->sem_nsems;		ibp->sem_nsems = bp->sem_nsems;
ibp->sem_otime = bp->sem_otime;		ibp->sem_otime = bp->sem_otime;
ibp->sem_ctime = bp->sem_ctime;		ibp->sem_ctime = bp->sem_ctime;
return;		return;
}		}

static void		static void
cvt_isemid2semid(ibp, bp)		cvt_isemid2semid(ibp, bp)
struct ibcs2_semid_ds *ibp;		struct ibcs2_semid_ds *ibp;
struct semid_ds *bp;		struct semid_ds *bp;
{		{
cvt_iperm2perm(&ibp->sem_perm, &bp->sem_perm);		cvt_iperm2perm(&ibp->sem_perm, &bp->sem_perm);
bp->sem_base = (struct sem *)ibp->sem_base;
bp->sem_nsems = ibp->sem_nsems;		bp->sem_nsems = ibp->sem_nsems;
bp->sem_otime = ibp->sem_otime;		bp->sem_otime = ibp->sem_otime;
bp->sem_ctime = ibp->sem_ctime;		bp->sem_ctime = ibp->sem_ctime;
return;		return;
}		}

struct ibcs2_semctl_args {		struct ibcs2_semctl_args {
int what;		int what;
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines