Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each.
Needs ReviewPublic
Actions

Authored by bz on Jun 19 2018, 4:36 PM.

Details

Reviewers

jamie
kib
jhb

Summary

Implement "global" process (and zombie) lists loops
iterating over all vps instances and all processes in each
(similarly to what was done for vnets).

There are a few per-vps cases which have been marked.

Pointed out by: kib
Sponsored by: iXsystems, Inc.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17446
Build 17278: arc lint + arc unit

Event Timeline

bz created this revision.Jun 19 2018, 4:36 PM

Herald added a subscriber: emaste. · View Herald TranscriptJun 19 2018, 4:36 PM

Harbormaster completed remote builds in B17446: Diff 44079.Jun 19 2018, 4:36 PM

I'll try to get some of the whitespace changes (using sub-functions for highly indented code, etc) out of this patch and into head separately to make it easier to review this one.

bz mentioned this in D15570: Virtualization of basic variables and locks for jail+vps..Jun 19 2018, 4:41 PM

Merge branch 'p1' into p2

Herald added a subscriber: ae. · View Herald TranscriptJul 11 2018, 2:54 PM

Harbormaster completed remote builds in B17981: Diff 45165.Jul 11 2018, 2:54 PM

Looks like there was an unlock lost during the merge.

Harbormaster completed remote builds in B17982: Diff 45168.Jul 11 2018, 3:48 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_current.c

25 lines

ddb/

db_command.c

19 lines

db_ps.c

21 lines

db_thread.c

2 lines

dev/

filemon/

filemon.c

29 lines

hwpmc/

hwpmc_mod.c

24 lines

fs/

pseudofs/

pseudofs_vnops.c

5 lines

i386/

ibcs2/

ibcs2_sysvec.c

19 lines

kern/

19 lines

1 line

207 lines

32 lines

211 lines

1 line

2 lines

4 lines

71 lines

183 lines

147 lines

132 lines

2 lines

2 lines

21 lines

8 lines

26 lines

27 lines

vm/

66 lines

25 lines

139 lines

322 lines

Diff 44079

View Options

sys/compat/linuxkpi/common/src/linux_current.c

Show All 37 Lines	struct ipc_perm32 {
gid_t gid;		gid_t gid;
mode_t mode;		mode_t mode;
uint16_t seq;		uint16_t seq;
uint32_t key;		uint32_t key;
};		};

struct semid_ds32 {		struct semid_ds32 {
struct ipc_perm32 sem_perm;		struct ipc_perm32 sem_perm;
uint32_t sem_base;		uint32_t __sem_base;
unsigned short sem_nsems;		unsigned short sem_nsems;
int32_t sem_otime;		int32_t sem_otime;
int32_t sem_ctime;		int32_t sem_ctime;
};		};

#ifdef _KERNEL		#ifdef _KERNEL
struct semid_kernel32 {		struct semid_kernel32 {
/* Data structure exposed to user space. */		/* Data structure exposed to user space. */
Show All 9 Lines
union semun32 {		union semun32 {
int val;		int val;
uint32_t buf;		uint32_t buf;
uint32_t array;		uint32_t array;
};		};

struct msqid_ds32 {		struct msqid_ds32 {
struct ipc_perm32 msg_perm;		struct ipc_perm32 msg_perm;
uint32_t msg_first;		uint32_t __msg_first;
uint32_t msg_last;		uint32_t __msg_last;
uint32_t msg_cbytes;		uint32_t msg_cbytes;
uint32_t msg_qnum;		uint32_t msg_qnum;
uint32_t msg_qbytes;		uint32_t msg_qbytes;
pid_t msg_lspid;		pid_t msg_lspid;
pid_t msg_lrpid;		pid_t msg_lrpid;
int32_t msg_stime;		int32_t msg_stime;
int32_t msg_rtime;		int32_t msg_rtime;
int32_t msg_ctime;		int32_t msg_ctime;
▲ Show 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	struct ipc_perm32_old {
uint16_t gid;		uint16_t gid;
uint16_t mode;		uint16_t mode;
uint16_t seq;		uint16_t seq;
uint32_t key;		uint32_t key;
};		};

struct semid_ds32_old {		struct semid_ds32_old {
struct ipc_perm32_old sem_perm;		struct ipc_perm32_old sem_perm;
uint32_t sem_base;		uint32_t __sem_base;
unsigned short sem_nsems;		unsigned short sem_nsems;
int32_t sem_otime;		int32_t sem_otime;
int32_t sem_pad1;		int32_t sem_pad1;
int32_t sem_ctime;		int32_t sem_ctime;
int32_t sem_pad2;		int32_t sem_pad2;
int32_t sem_pad3[4];		int32_t sem_pad3[4];
};		};

struct msqid_ds32_old {		struct msqid_ds32_old {
struct ipc_perm32_old msg_perm;		struct ipc_perm32_old msg_perm;
uint32_t msg_first;		uint32_t __msg_first;
uint32_t msg_last;		uint32_t __msg_last;
uint32_t msg_cbytes;		uint32_t msg_cbytes;
uint32_t msg_qnum;		uint32_t msg_qnum;
uint32_t msg_qbytes;		uint32_t msg_qbytes;
pid_t msg_lspid;		pid_t msg_lspid;
pid_t msg_lrpid;		pid_t msg_lrpid;
int32_t msg_stime;		int32_t msg_stime;
int32_t msg_pad1;		int32_t msg_pad1;
int32_t msg_rtime;		int32_t msg_rtime;
Show All 28 Lines

View Options

sys/ddb/db_command.c

Show All 37 Lines	struct ipc_perm32 {
gid_t gid;		gid_t gid;
mode_t mode;		mode_t mode;
uint16_t seq;		uint16_t seq;
uint32_t key;		uint32_t key;
};		};

struct semid_ds32 {		struct semid_ds32 {
struct ipc_perm32 sem_perm;		struct ipc_perm32 sem_perm;
uint32_t sem_base;		uint32_t __sem_base;
unsigned short sem_nsems;		unsigned short sem_nsems;
int32_t sem_otime;		int32_t sem_otime;
int32_t sem_ctime;		int32_t sem_ctime;
};		};

#ifdef _KERNEL		#ifdef _KERNEL
struct semid_kernel32 {		struct semid_kernel32 {
/* Data structure exposed to user space. */		/* Data structure exposed to user space. */
Show All 9 Lines
union semun32 {		union semun32 {
int val;		int val;
uint32_t buf;		uint32_t buf;
uint32_t array;		uint32_t array;
};		};

struct msqid_ds32 {		struct msqid_ds32 {
struct ipc_perm32 msg_perm;		struct ipc_perm32 msg_perm;
uint32_t msg_first;		uint32_t __msg_first;
uint32_t msg_last;		uint32_t __msg_last;
uint32_t msg_cbytes;		uint32_t msg_cbytes;
uint32_t msg_qnum;		uint32_t msg_qnum;
uint32_t msg_qbytes;		uint32_t msg_qbytes;
pid_t msg_lspid;		pid_t msg_lspid;
pid_t msg_lrpid;		pid_t msg_lrpid;
int32_t msg_stime;		int32_t msg_stime;
int32_t msg_rtime;		int32_t msg_rtime;
int32_t msg_ctime;		int32_t msg_ctime;
▲ Show 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	struct ipc_perm32_old {
uint16_t gid;		uint16_t gid;
uint16_t mode;		uint16_t mode;
uint16_t seq;		uint16_t seq;
uint32_t key;		uint32_t key;
};		};

struct semid_ds32_old {		struct semid_ds32_old {
struct ipc_perm32_old sem_perm;		struct ipc_perm32_old sem_perm;
uint32_t sem_base;		uint32_t __sem_base;
unsigned short sem_nsems;		unsigned short sem_nsems;
int32_t sem_otime;		int32_t sem_otime;
int32_t sem_pad1;		int32_t sem_pad1;
int32_t sem_ctime;		int32_t sem_ctime;
int32_t sem_pad2;		int32_t sem_pad2;
int32_t sem_pad3[4];		int32_t sem_pad3[4];
};		};

struct msqid_ds32_old {		struct msqid_ds32_old {
struct ipc_perm32_old msg_perm;		struct ipc_perm32_old msg_perm;
uint32_t msg_first;		uint32_t __msg_first;
uint32_t msg_last;		uint32_t __msg_last;
uint32_t msg_cbytes;		uint32_t msg_cbytes;
uint32_t msg_qnum;		uint32_t msg_qnum;
uint32_t msg_qbytes;		uint32_t msg_qbytes;
pid_t msg_lspid;		pid_t msg_lspid;
pid_t msg_lrpid;		pid_t msg_lrpid;
int32_t msg_stime;		int32_t msg_stime;
int32_t msg_pad1;		int32_t msg_pad1;
int32_t msg_rtime;		int32_t msg_rtime;
Show All 28 Lines

View Options

sys/ddb/db_ps.c

Show All 37 Lines	struct ipc_perm32 {
gid_t gid;		gid_t gid;
mode_t mode;		mode_t mode;
uint16_t seq;		uint16_t seq;
uint32_t key;		uint32_t key;
};		};

struct semid_ds32 {		struct semid_ds32 {
struct ipc_perm32 sem_perm;		struct ipc_perm32 sem_perm;
uint32_t sem_base;		uint32_t __sem_base;
unsigned short sem_nsems;		unsigned short sem_nsems;
int32_t sem_otime;		int32_t sem_otime;
int32_t sem_ctime;		int32_t sem_ctime;
};		};

#ifdef _KERNEL		#ifdef _KERNEL
struct semid_kernel32 {		struct semid_kernel32 {
/* Data structure exposed to user space. */		/* Data structure exposed to user space. */
Show All 9 Lines
union semun32 {		union semun32 {
int val;		int val;
uint32_t buf;		uint32_t buf;
uint32_t array;		uint32_t array;
};		};

struct msqid_ds32 {		struct msqid_ds32 {
struct ipc_perm32 msg_perm;		struct ipc_perm32 msg_perm;
uint32_t msg_first;		uint32_t __msg_first;
uint32_t msg_last;		uint32_t __msg_last;
uint32_t msg_cbytes;		uint32_t msg_cbytes;
uint32_t msg_qnum;		uint32_t msg_qnum;
uint32_t msg_qbytes;		uint32_t msg_qbytes;
pid_t msg_lspid;		pid_t msg_lspid;
pid_t msg_lrpid;		pid_t msg_lrpid;
int32_t msg_stime;		int32_t msg_stime;
int32_t msg_rtime;		int32_t msg_rtime;
int32_t msg_ctime;		int32_t msg_ctime;
▲ Show 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	struct ipc_perm32_old {
uint16_t gid;		uint16_t gid;
uint16_t mode;		uint16_t mode;
uint16_t seq;		uint16_t seq;
uint32_t key;		uint32_t key;
};		};

struct semid_ds32_old {		struct semid_ds32_old {
struct ipc_perm32_old sem_perm;		struct ipc_perm32_old sem_perm;
uint32_t sem_base;		uint32_t __sem_base;
unsigned short sem_nsems;		unsigned short sem_nsems;
int32_t sem_otime;		int32_t sem_otime;
int32_t sem_pad1;		int32_t sem_pad1;
int32_t sem_ctime;		int32_t sem_ctime;
int32_t sem_pad2;		int32_t sem_pad2;
int32_t sem_pad3[4];		int32_t sem_pad3[4];
};		};

struct msqid_ds32_old {		struct msqid_ds32_old {
struct ipc_perm32_old msg_perm;		struct ipc_perm32_old msg_perm;
uint32_t msg_first;		uint32_t __msg_first;
uint32_t msg_last;		uint32_t __msg_last;
uint32_t msg_cbytes;		uint32_t msg_cbytes;
uint32_t msg_qnum;		uint32_t msg_qnum;
uint32_t msg_qbytes;		uint32_t msg_qbytes;
pid_t msg_lspid;		pid_t msg_lspid;
pid_t msg_lrpid;		pid_t msg_lrpid;
int32_t msg_stime;		int32_t msg_stime;
int32_t msg_pad1;		int32_t msg_pad1;
int32_t msg_rtime;		int32_t msg_rtime;
Show All 28 Lines

View Options

sys/ddb/db_thread.c

Show All 37 Lines	struct ipc_perm32 {
gid_t gid;		gid_t gid;
mode_t mode;		mode_t mode;
uint16_t seq;		uint16_t seq;
uint32_t key;		uint32_t key;
};		};

struct semid_ds32 {		struct semid_ds32 {
struct ipc_perm32 sem_perm;		struct ipc_perm32 sem_perm;
uint32_t sem_base;		uint32_t __sem_base;
unsigned short sem_nsems;		unsigned short sem_nsems;
int32_t sem_otime;		int32_t sem_otime;
int32_t sem_ctime;		int32_t sem_ctime;
};		};

#ifdef _KERNEL		#ifdef _KERNEL
struct semid_kernel32 {		struct semid_kernel32 {
/* Data structure exposed to user space. */		/* Data structure exposed to user space. */
Show All 9 Lines
union semun32 {		union semun32 {
int val;		int val;
uint32_t buf;		uint32_t buf;
uint32_t array;		uint32_t array;
};		};

struct msqid_ds32 {		struct msqid_ds32 {
struct ipc_perm32 msg_perm;		struct ipc_perm32 msg_perm;
uint32_t msg_first;		uint32_t __msg_first;
uint32_t msg_last;		uint32_t __msg_last;
uint32_t msg_cbytes;		uint32_t msg_cbytes;
uint32_t msg_qnum;		uint32_t msg_qnum;
uint32_t msg_qbytes;		uint32_t msg_qbytes;
pid_t msg_lspid;		pid_t msg_lspid;
pid_t msg_lrpid;		pid_t msg_lrpid;
int32_t msg_stime;		int32_t msg_stime;
int32_t msg_rtime;		int32_t msg_rtime;
int32_t msg_ctime;		int32_t msg_ctime;
▲ Show 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	struct ipc_perm32_old {
uint16_t gid;		uint16_t gid;
uint16_t mode;		uint16_t mode;
uint16_t seq;		uint16_t seq;
uint32_t key;		uint32_t key;
};		};

struct semid_ds32_old {		struct semid_ds32_old {
struct ipc_perm32_old sem_perm;		struct ipc_perm32_old sem_perm;
uint32_t sem_base;		uint32_t __sem_base;
unsigned short sem_nsems;		unsigned short sem_nsems;
int32_t sem_otime;		int32_t sem_otime;
int32_t sem_pad1;		int32_t sem_pad1;
int32_t sem_ctime;		int32_t sem_ctime;
int32_t sem_pad2;		int32_t sem_pad2;
int32_t sem_pad3[4];		int32_t sem_pad3[4];
};		};

struct msqid_ds32_old {		struct msqid_ds32_old {
struct ipc_perm32_old msg_perm;		struct ipc_perm32_old msg_perm;
uint32_t msg_first;		uint32_t __msg_first;
uint32_t msg_last;		uint32_t __msg_last;
uint32_t msg_cbytes;		uint32_t msg_cbytes;
uint32_t msg_qnum;		uint32_t msg_qnum;
uint32_t msg_qbytes;		uint32_t msg_qbytes;
pid_t msg_lspid;		pid_t msg_lspid;
pid_t msg_lrpid;		pid_t msg_lrpid;
int32_t msg_stime;		int32_t msg_stime;
int32_t msg_pad1;		int32_t msg_pad1;
int32_t msg_rtime;		int32_t msg_rtime;
Show All 28 Lines