Page MenuHomeFreeBSD

Syscalls concerned with modifying/deleting the extended attributes of a file
ClosedPublic

Authored by aniketp on Jun 17 2018, 5:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 11, 9:48 AM
Unknown Object (File)
Sun, Mar 8, 8:55 PM
Unknown Object (File)
Sun, Mar 8, 9:18 AM
Unknown Object (File)
Sat, Mar 7, 9:37 PM
Unknown Object (File)
Fri, Mar 6, 4:08 PM
Unknown Object (File)
Fri, Feb 27, 4:12 AM
Unknown Object (File)
Wed, Feb 18, 1:39 PM
Unknown Object (File)
Dec 20 2025, 11:03 AM
Subscribers

Details

Summary

This revision introduces test-cases for checking the proper auditability of syscalls
concerned with modifying/deleting the extended attributes of a file or a symbolic link.
The system calls are categorized within file-attribute-modify audit class.
List of syscalls are:

  • extattr_set_file(2)
  • extattr_set_fd(2)
  • extattr_set_link(2)
  • extattr_delete_file(2)
  • extattr_delete_fd(2)
  • extattr_delete_link(2)
Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers requested changes to this revision.Jun 17 2018, 9:39 PM
asomers added inline comments.
tests/sys/audit/file-attribute-modify.c
42 ↗(On Diff #43956)

It's confusing to name this variable readbuff, because it isn't a buffer. Could you please pick a different name?

This revision now requires changes to proceed.Jun 17 2018, 9:39 PM

Replace readbuff with retval since it is a simple return value instead of a buffer
i.e return value of extattr_delete_{file/fd/link}

This revision is now accepted and ready to land.Jun 18 2018, 2:59 PM
This revision was automatically updated to reflect the committed changes.